Skip to content

Fix Sysbench TPCC PopulateDatabase passing --warehouses 0 on small VMs #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexW-F merged 2 commits into from
Apr 6, 2026
+2 −2
Merged

Fix Sysbench TPCC PopulateDatabase passing --warehouses 0 on small VMs #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b49755e
Fix Sysbench TPCC PopulateDatabase passing --warehouses 0 on small VMs
Apr 6, 2026
b25c390
Merge branch 'main' into users/alexwill/sysbench0fix
AlexW-F Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/VirtualClient/VirtualClient.Actions.UnitTests/Sysbench/SysbenchConfigurationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public async Task SysbenchConfigurationProperlyExecutesTPCCPreparation()

string[] expectedCommands =
{
$"python3 {this.mockPackagePath}/populate-database.py --dbName sbtest --databaseSystem MySQL --benchmark TPCC --threadCount 8 --tableCount 10 --warehouses 0 --password [A-Za-z0-9+/=]+ --hostIpAddress \"1.2.3.5\""
$"python3 {this.mockPackagePath}/populate-database.py --dbName sbtest --databaseSystem MySQL --benchmark TPCC --threadCount 8 --tableCount 10 --warehouses 1 --password [A-Za-z0-9+/=]+ --hostIpAddress \"1.2.3.5\""
};

int commandNumber = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/VirtualClient/VirtualClient.Actions/Sysbench/SysbenchExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,7 @@ protected string BuildSysbenchLoggingArguments(SysbenchMode mode)
int warehouseCount = mode switch
{
SysbenchMode.Prepare => 1,
SysbenchMode.Populate => warehouseEstimate - 1,
SysbenchMode.Populate => Math.Max(1, warehouseEstimate - 1),
SysbenchMode.Run => warehouseEstimate,
_ => warehouseEstimate
};
Expand Down
Loading