Fix Sysbench TPCC PopulateDatabase passing --warehouses 0 on small VMs#675
Merged
Fix Sysbench TPCC PopulateDatabase passing --warehouses 0 on small VMs#675
Conversation
On VMs with 4 vCPUs or fewer, GetWarehouseCount returns 1, causing the Populate mode calculation (warehouseEstimate - 1) to yield 0. This passes --warehouses 0 to populate-database.py, which calls sysbench tpcc prepare with --scale=0, dropping and recreating all tables with zero data. The client then fails with nil value errors on every run attempt. Fix: Use Math.Max(1, warehouseEstimate - 1) to ensure at least 1 warehouse is always passed to the populate step. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ericavella
approved these changes
Apr 6, 2026
ericavella
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On VMs with 4 vCPUs or fewer, GetWarehouseCount returns 1, causing the Populate mode calculation (warehouseEstimate - 1) to yield 0. This passes --warehouses 0 to populate-database.py, which calls sysbench tpcc prepare with --scale=0, dropping and recreating all tables with zero data. The client then fails with nil value errors on every run attempt.
Fix: Use Math.Max(1, warehouseEstimate - 1) to ensure at least 1 warehouse is always passed to the populate step.