Skip to content

test: address flake. #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knightedcodemonkey merged 1 commit into from
Apr 19, 2026
Merged

test: address flake. #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions playwright/rendering-modes.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@
].join('\n'),
)

await expect(page.locator('#preview-host pre')).toHaveCount(0)

Check failure on line 399 in playwright/rendering-modes.spec.ts

View workflow job for this annotation

GitHub Actions / E2E (Playwright, webkit, shard 3/4)

[webkit] › playwright/rendering-modes.spec.ts:374:1 › editing-transient missing reference runtime errors are suppressed 

  2) [webkit] › playwright/rendering-modes.spec.ts:374:1 › editing-transient missing reference runtime errors are suppressed 
    Error: expect(locator).toHaveCount(expected) failed

    Locator:  locator('#preview-host pre')
    Expected: 0
    Received: 1
    Timeout:  90000ms

    Call log:
      - Expect "toHaveCount" with timeout 90000ms
      - waiting for locator('#preview-host pre')
        93 × locator resolved to 1 element
           - unexpected value "1"


      397 |   )
      398 |
    > 399 |   await expect(page.locator('#preview-host pre')).toHaveCount(0)
          |                                                   ^
      400 |   await expect(page.getByRole('status', { name: 'App status' })).not.toHaveText('Error')
      401 | })
      402 |
        at /home/runner/work/develop/develop/playwright/rendering-modes.spec.ts:399:51
await expect(page.getByRole('status', { name: 'App status' })).not.toHaveText('Error')
})

Expand Down Expand Up @@ -595,10 +595,14 @@
)

await page.getByRole('combobox', { name: 'Render mode' }).selectOption('react')
await expect(page.getByRole('combobox', { name: 'Render mode' })).toHaveValue('react')
await setComponentEditorSource(
page,
'const Button = () => <button type="button">implicit app react</button>',
)
await expect(
page.locator('.editor-panel[data-editor-kind="component"] .cm-content').first(),
).toContainText('implicit app react')

await expect(page.getByRole('status', { name: 'App status' })).toHaveText('Rendered')
await expect(getPreviewFrame(page).getByRole('button')).toContainText(
Expand Down Expand Up @@ -720,13 +724,13 @@

await ensurePanelToolsVisible(page, 'styles')
await page.getByRole('combobox', { name: 'Style mode' }).selectOption('sass')
await expect(page.locator('#style-mode')).toHaveValue('sass')
await expect(page.getByRole('status', { name: 'App status' })).toHaveText('Rendered')

await page.reload()
await waitForInitialRender(page)
await ensurePanelToolsVisible(page, 'styles')

await expect(page.getByRole('combobox', { name: 'Style mode' })).toHaveValue('sass')
await expect(page.locator('#style-mode')).toHaveValue('sass')
})

test('renders with less style mode', async ({ page }) => {
Expand Down
1 change: 1 addition & 0 deletions src/modules/app-core/workspace-controllers-setup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,7 @@ const createWorkspaceControllersSetup = ({
getDirtyStateForTabChange,
syncHeaderLabels,
queueWorkspaceSave,
flushWorkspaceSave,
maybeRender: () => maybeRender(),
setWorkspaceTabAddMenuOpen,
confirmAction,
Expand Down
9 changes: 8 additions & 1 deletion src/modules/app-core/workspace-tab-mutations-controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const createWorkspaceTabMutationsController = ({
getDirtyStateForTabChange,
syncHeaderLabels,
queueWorkspaceSave,
flushWorkspaceSave,
maybeRender,
setWorkspaceTabAddMenuOpen,
confirmAction,
Expand Down Expand Up @@ -143,7 +144,13 @@ const createWorkspaceTabMutationsController = ({
}

renderWorkspaceTabs()
queueWorkspaceSave()
if (typeof flushWorkspaceSave === 'function') {
void flushWorkspaceSave().catch(() => {
/* Save failures are surfaced through workspace saver onError. */
})
} else {
queueWorkspaceSave()
}
maybeRender()
},
})
Expand Down
Loading