Skip to content

test: address flake.#84

Merged
knightedcodemonkey merged 1 commit intonextfrom
bananas
Apr 19, 2026
Merged

test: address flake.#84
knightedcodemonkey merged 1 commit intonextfrom
bananas

Conversation

@knightedcodemonkey
Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings April 18, 2026 20:44
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Addresses a flaky Playwright test by adding stronger UI state assertions and ensuring workspace tab removals trigger an immediate save.

Changes:

  • Trigger flushWorkspaceSave() (when available) after removing a workspace tab instead of only queuing a debounced save.
  • Add Playwright assertions to wait for render-mode/style-mode selects and editor content to reflect changes before continuing.
  • Simplify the “persists style mode across reload” test assertions to rely on #style-mode value across reload.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/modules/app-core/workspace-tab-mutations-controller.js Flushes workspace save immediately after a tab removal to reduce persistence race conditions.
src/modules/app-core/workspace-controllers-setup.js Wires flushWorkspaceSave into the tab mutations controller.
playwright/rendering-modes.spec.ts Adds synchronization expectations to reduce flakiness around mode switching and editor updates.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@knightedcodemonkey knightedcodemonkey merged commit b0599bc into next Apr 19, 2026
14 of 15 checks passed
@knightedcodemonkey knightedcodemonkey deleted the bananas branch April 19, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants