Skip to content

Fixed rendering test failure for heterogeneous dexsuite on Newton + IsaacRTX#6166

Open
huidongc wants to merge 1 commit into
isaac-sim:release/3.0.0-beta2from
huidongc:fix-test-only-failure
Open

Fixed rendering test failure for heterogeneous dexsuite on Newton + IsaacRTX#6166
huidongc wants to merge 1 commit into
isaac-sim:release/3.0.0-beta2from
huidongc:fix-test-only-failure

Conversation

@huidongc

@huidongc huidongc commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Description

Followup #5979 : on release/3.0.0-beta2, the flag is set in launch_simulation() as a workaround to keep USD cloning enabled when using Isaac RTX renderer. The test has to set the flag manually here to match the behavior of training.

Type of change

  • Test fix (non-breaking change which fixes an issue)

Screenshots

See golden image changes.

Checklist

  • I have read and understood the contribution guidelines
  • I have run the pre-commit checks with ./isaaclab.sh --format
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the changelog and the corresponding version in the extension's config/extension.toml file
  • I have added my name to the CONTRIBUTORS.md or my name already exists there

…imulation() as a workaround to keep USD cloning enabled when using Isaac RTX renderer. The test has to set the flag manually here to match the behavior of training.
@github-actions github-actions Bot added bug Something isn't working isaac-lab Related to Isaac Lab team labels Jun 12, 2026
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a rendering test failure for the heterogeneous DexSuite Kuka environment on Newton + IsaacRTX by manually setting the /isaaclab/runtime/needs_kit flag in the test, mirroring the flag set by launch_simulation() during training. Updated golden images reflect the corrected rendering output.

  • Sets /isaaclab/runtime/needs_kit to True before running the isaacsim_rtx_renderer test path, exactly paralleling the existing ovrtx_renderer workaround, and resets it to False in the finally cleanup block.
  • Replaces 8 LFS-tracked golden images for the dexsuite_kuka_hetero test case under newton-isaacsim_rtx_renderer with images produced with USD cloning correctly enabled.

Confidence Score: 5/5

The change is a narrow, well-scoped test fix that mirrors an already-established pattern for a different renderer.

The new isaacsim_rtx_renderer branch follows the identical set-before/reset-in-finally pattern already used for ovrtx_renderer. The flag /isaaclab/runtime/needs_kit is the same one that launch_simulation() sets at line 477 of sim_launcher.py, so the test now matches training-time behavior. Golden images are straightforward LFS pointer replacements. No logic shared with other code paths is modified.

No files require special attention.

Important Files Changed

Filename Overview
source/isaaclab_tasks/test/rendering_test_utils.py Adds isaacsim_rtx_renderer branch to set/reset /isaaclab/runtime/needs_kit, matching the training-time behavior set by launch_simulation() and the existing ovrtx_renderer pattern.
source/isaaclab_tasks/test/golden_images/dexsuite_kuka_hetero/newton-isaacsim_rtx_renderer-rgb.png LFS pointer update for the RGB golden image reflecting correct rendering with USD cloning enabled.
source/isaaclab_tasks/changelog.d/huidongc-fix-test-failure.skip Empty .skip file used as a changelog placeholder; no functional changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[rendering_test_dexsuite_kuka called] --> B{renderer?}
    B -- ovrtx_renderer --> C[set has_ovrtx_renderer = True]
    B -- isaacsim_rtx_renderer --> D[set needs_kit = True - NEW]
    B -- other --> E[no flag set]
    C --> F[env setup and camera validation]
    D --> F
    E --> F
    F --> G{try/finally}
    G -- finally: ovrtx_renderer --> H[set has_ovrtx_renderer = False]
    G -- finally: isaacsim_rtx_renderer --> I[set needs_kit = False - NEW]
    G -- finally: other --> J[no cleanup]
Loading

Reviews (1): Last reviewed commit: "PR#5979 followup: on release/3.0.0-beta2..." | Re-trigger Greptile

@huidongc huidongc requested a review from ooctipus June 12, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working isaac-lab Related to Isaac Lab team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant