Fixed rendering test failure for heterogeneous dexsuite on Newton + IsaacRTX#6166
Fixed rendering test failure for heterogeneous dexsuite on Newton + IsaacRTX#6166huidongc wants to merge 1 commit into
Conversation
…imulation() as a workaround to keep USD cloning enabled when using Isaac RTX renderer. The test has to set the flag manually here to match the behavior of training.
Greptile SummaryThis PR fixes a rendering test failure for the heterogeneous DexSuite Kuka environment on Newton + IsaacRTX by manually setting the
Confidence Score: 5/5The change is a narrow, well-scoped test fix that mirrors an already-established pattern for a different renderer. The new isaacsim_rtx_renderer branch follows the identical set-before/reset-in-finally pattern already used for ovrtx_renderer. The flag /isaaclab/runtime/needs_kit is the same one that launch_simulation() sets at line 477 of sim_launcher.py, so the test now matches training-time behavior. Golden images are straightforward LFS pointer replacements. No logic shared with other code paths is modified. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[rendering_test_dexsuite_kuka called] --> B{renderer?}
B -- ovrtx_renderer --> C[set has_ovrtx_renderer = True]
B -- isaacsim_rtx_renderer --> D[set needs_kit = True - NEW]
B -- other --> E[no flag set]
C --> F[env setup and camera validation]
D --> F
E --> F
F --> G{try/finally}
G -- finally: ovrtx_renderer --> H[set has_ovrtx_renderer = False]
G -- finally: isaacsim_rtx_renderer --> I[set needs_kit = False - NEW]
G -- finally: other --> J[no cleanup]
Reviews (1): Last reviewed commit: "PR#5979 followup: on release/3.0.0-beta2..." | Re-trigger Greptile |
Description
Followup #5979 : on release/3.0.0-beta2, the flag is set in launch_simulation() as a workaround to keep USD cloning enabled when using Isaac RTX renderer. The test has to set the flag manually here to match the behavior of training.
Type of change
Screenshots
See golden image changes.
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there