Skip to content

fix: telemetry for power util not collected when turbostat output doesn't include Package field, e.g., single socket + UMA #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harp-intel merged 1 commit into from
Apr 23, 2026
+46 −5
Merged

fix: telemetry for power util not collected when turbostat output doesn't include Package field, e.g., single socket + UMA #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions internal/extract/turbostat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,12 +364,25 @@ func TurbostatPackageRows(turboStatScriptOutput string, fieldNames []string) ([]
func extractPackageRows(rows []map[string]string) ([]map[string]string, error) {
var packageRows []map[string]string
for i, row := range rows {
if val, ok := row["Package"]; ok && val != "-" && row["Core"] == "0" {
if i > 0 && rows[i-1]["Package"] == val && rows[i-1]["Core"] == "0" {
// This is the hyperthread associated with the package row, skip it
continue
// if we have a "Package" field
if pkg, ok := row["Package"]; ok {
if pkg != "-" && row["Core"] == "0" {
if i > 0 && rows[i-1]["Package"] == pkg && rows[i-1]["Core"] == "0" {
// This is the hyperthread associated with the package row, skip it
continue
}
packageRows = append(packageRows, row)
}
} else { // if no "Package" field, identify package rows by Core 0
if row["Core"] == "0" {
if i > 0 && rows[i-1]["Core"] == "0" {
// This is the hyperthread associated with the package row, skip it
continue
}
if cpu, ok := row["CPU"]; ok && cpu == "0" {
packageRows = append(packageRows, row)
}
}
packageRows = append(packageRows, row)
}
}
return packageRows, nil
Expand Down
28 changes: 28 additions & 0 deletions internal/extract/turbostat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,26 @@ Package Core CPU Avg_MHz Busy% Bzy_MHz TSC_MHz IPC IRQ SMI
1 1 193 1 0.02 3885 2000 0.30 26 0 0 0 0 27 0.00 0.00 0.00 99.99 0.02
`

const turbostatOutputNoPackage = `TIME: 13:55:22
INTERVAL: 2
Core CPU Avg_MHz Busy% Bzy_MHz TSC_MHz IPC IRQ NMI SMI LLCkRPS LLC%hit POLL% C1% C1E% C6% C6P% CPU%c1 CPU%c6 CoreTmp CoreThr PkgTmp Pkg%pc2 Pkg%pc6 PkgWatt RAMWatt PKG_% RAM_% UMHz0.0 UMHz1.0 UMHz2.0 UMHz3.0 UMHz4.0 SysWatt
- - 2745 95.78 2855 2008 1.89 582397 70 0 17746 87.03 0.00 0.00 3.94 0.00 0.00 2.73 0.00 59 0 59 0.00 0.00 406.56 6.20 894601.29 0.00 2200 2200 2200 2500 2500 0.00
0 0 2744 96.52 2843 2000 1.87 2583 0 0 103 97.44 0.00 0.00 3.16 0.00 0.00 3.00 0.00 50 0 59 0.00 0.00 401.78 6.13 884085.02 0.00 2200 2200 2200 2500 2500
0 128 2725 95.73 2847 2000 1.86 2248 0 0 89 80.52 0.00 0.00 4.04 0.00 0.00 3.00
1 1 2717 95.47 2846 2000 1.87 2285 0 0 83 97.44 0.00 0.00 4.23 0.00 0.00 3.15 0.00 53 0
1 129 2737 96.21 2845 2000 1.89 2270 0 0 56 88.03 0.00 0.00 3.56 0.00 0.00 3.15
2 2 2729 95.98 2843 2000 1.87 2267 0 0 48 95.46 0.00 0.00 3.68 0.00 0.00 2.95 0.00 52 0
2 130 2728 95.75 2849 2000 1.88 2255 0 0 55 88.07 0.00 0.00 4.02 0.00 0.00 2.95
Core CPU Avg_MHz Busy% Bzy_MHz TSC_MHz IPC IRQ NMI SMI LLCkRPS LLC%hit POLL% C1% C1E% C6% C6P% CPU%c1 CPU%c6 CoreTmp CoreThr PkgTmp Pkg%pc2 Pkg%pc6 PkgWatt RAMWatt PKG_% RAM_% UMHz0.0 UMHz1.0 UMHz2.0 UMHz3.0 UMHz4.0 SysWatt
- - 2073 95.15 2184 1995 1.83 569520 52 0 21009 95.08 0.00 0.00 4.47 0.00 0.00 2.87 0.00 63 0 62 0.00 0.00 363.13 6.02 0.00 0.00 1900 1900 1900 1900 1900 0.00
0 0 2084 95.49 2183 2000 1.80 2537 1 0 150 98.35 0.00 0.00 4.29 0.00 0.00 3.54 0.00 53 0 62 0.00 0.00 364.84 6.05 0.00 0.00 1900 1900 1900 1900 1900
0 128 2090 95.65 2185 2000 1.81 2229 1 0 144 83.50 0.00 0.00 3.85 0.00 0.00 3.54
1 1 2116 96.44 2194 2000 1.84 2263 0 0 67 97.66 0.00 0.00 3.33 0.00 0.00 2.80 0.00 56 0
1 129 2069 94.81 2182 2000 1.80 2218 0 0 73 97.75 0.00 0.00 4.59 0.00 0.00 2.80
2 2 2107 95.92 2197 2000 1.87 2243 1 0 89 96.75 0.00 0.00 3.86 0.00 0.00 2.72 0.00 55 0
2 130 2076 95.15 2181 2000 1.83 2235 0 0 61 97.33 0.00 0.00 4.22 0.00 0.00 2.72
`

func TestTurbostatPlatformRows(t *testing.T) {
tests := []struct {
name string
Expand Down Expand Up @@ -117,6 +137,14 @@ func TestTurbostatPlatformRows(t *testing.T) {
wantLen: 0,
expectErr: true,
},
{
name: "No package field, identify by core 0",
turbostatOutput: turbostatOutputNoPackage,
fieldNames: []string{"Avg_MHz", "Busy%"},
wantFirst: []string{"13:55:22", "2745", "95.78"},
wantLen: 2,
expectErr: false,
},
}

for _, tt := range tests {
Expand Down
Loading