fix: telemetry for power util not collected when turbostat output doesn't include Package field, e.g., single socket + UMA#690
Merged
harp-intel merged 1 commit intomainfrom Apr 23, 2026
Conversation
…sn't include Package field, e.g., single socket + UMA Co-authored-by: Copilot <copilot@github.com> Signed-off-by: Harper, Jason M <jason.m.harper@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the logic for extracting package rows from turbostat output, especially for cases where the "Package" field is missing, and adds corresponding test coverage to ensure correctness.
Enhancements to package row extraction:
extractPackageRowsfunction inturbostat.goto handle cases where the "Package" field is absent. The new logic identifies package rows by checking forCore == "0"and, as an additional safeguard, only includes rows whereCPU == "0". This ensures robust extraction across different turbostat output formats.Test coverage improvements:
turbostatOutputNoPackage) inturbostat_test.goto verify that package rows are correctly identified even when the "Package" field is missing. The test checks that the extraction logic returns the correct rows and length. [1] [2]Co-authored-by: Copilot copilot@github.com Signed-off-by: Harper, Jason M jason.m.harper@intel.com