Skip to content

feat(calendar): Readded multiple groups and added blocked groups#456

Open
lwcorp wants to merge 1 commit intogoogleworkspace:mainfrom
lwcorp:patch-1
Open

feat(calendar): Readded multiple groups and added blocked groups#456
lwcorp wants to merge 1 commit intogoogleworkspace:mainfrom
lwcorp:patch-1

Conversation

@lwcorp
Copy link
Copy Markdown
Contributor

@lwcorp lwcorp commented Apr 15, 2024

Description

  1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?)
  2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
  3. Added support for avoiding blocked groups (e.g. external ones)
  4. Simplified both functions' code
  5. Fixed spelling while at it (hope it's okay to avoid an extra PR just to put fix in the title instead of feat)

Update - removed as newer updates stopped checking summaries:
6. Fixed to prevent script crash when any event has no summary

Is it been tested?

  • Development testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@lwcorp
Copy link
Copy Markdown
Contributor Author

lwcorp commented Apr 15, 2024

Please note the failed tests failed Google's own original code, not my additions.

Copy link
Copy Markdown

@baveer baveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code works great for single group, nested groups and multiple groups (which was broken by someone else). I have no idea why these tests failed, several calendars are up and running in my environment.

1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?)
2. Made the multiple groups and get all members functions to use each other to avoid duplicated code
3. Added support for avoiding blocked groups (e.g. external ones)
4. Simplified both functions' code
5. Fixed spelling while at it (hope it's okay to avoid an extra PR just to put `fix` in the title instead of `feat`)
@lwcorp lwcorp reopened this Apr 18, 2026
@lwcorp
Copy link
Copy Markdown
Contributor Author

lwcorp commented Apr 18, 2026

Refactored code to match newer merged PRs.
Please consider approving as it's shame to lose a the vital multiple groups' feature which you've accidentally removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants