feat(calendar): Readded multiple groups and added blocked groups#456
Open
lwcorp wants to merge 1 commit intogoogleworkspace:mainfrom
Open
feat(calendar): Readded multiple groups and added blocked groups#456lwcorp wants to merge 1 commit intogoogleworkspace:mainfrom
lwcorp wants to merge 1 commit intogoogleworkspace:mainfrom
Conversation
Contributor
Author
|
Please note the failed tests failed Google's own original code, not my additions. |
baveer
approved these changes
Apr 16, 2024
baveer
left a comment
There was a problem hiding this comment.
The code works great for single group, nested groups and multiple groups (which was broken by someone else). I have no idea why these tests failed, several calendars are up and running in my environment.
This was referenced Apr 16, 2024
Closed
1. Undid the removal of the support for multiple groups (why did you allow this person's PR just so they fix formatting?) 2. Made the multiple groups and get all members functions to use each other to avoid duplicated code 3. Added support for avoiding blocked groups (e.g. external ones) 4. Simplified both functions' code 5. Fixed spelling while at it (hope it's okay to avoid an extra PR just to put `fix` in the title instead of `feat`)
Contributor
Author
|
Refactored code to match newer merged PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixin the title instead offeat)Update - removed as newer updates stopped checking summaries:
6. Fixed to prevent script crash when any event has no summaryIs it been tested?
Checklist