Skip to content

parameterize BigQuery system tests for picosecond support #7975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
danieljbruce wants to merge 1 commit into from
Closed

parameterize BigQuery system tests for picosecond support #7975

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 33 additions & 7 deletions handwritten/bigquery/system-test/bigquery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,39 @@ import {
} from '../src';
import bq from '../src/types';

const bigquery = new BigQuery();
const storage = new Storage();
let bigquery = new BigQuery();
let storage = new Storage();

const runTests = (supportPicoseconds: boolean | undefined) => {
const label = supportPicoseconds ? 'with pico' : 'without pico';

describe(`BigQuery (${label})`, () => {
const originalValue = process.env.BIGQUERY_PICOSECOND_SUPPORT;

let dataset = bigquery.dataset(generateName('dataset'));
let table = dataset.table(generateName('table'));
let bucket = storage.bucket(generateName('bucket'));

before(() => {
if (supportPicoseconds === undefined) {
delete process.env.BIGQUERY_PICOSECOND_SUPPORT;
} else {
process.env.BIGQUERY_PICOSECOND_SUPPORT = 'true';
}
bigquery = new BigQuery();
storage = new Storage();
dataset = bigquery.dataset(generateName('dataset'));
table = dataset.table(generateName('table'));
bucket = storage.bucket(generateName('bucket'));
});

after(() => {
process.env.BIGQUERY_PICOSECOND_SUPPORT = originalValue;
});

describe('BigQuery', () => {
const GCLOUD_TESTS_PREFIX = 'nodejs_bq_test';
const minCreationTime = Date.now().toString();

const dataset = bigquery.dataset(generateName('dataset'));
const table = dataset.table(generateName('table'));
const bucket = storage.bucket(generateName('bucket'));

const query = 'SELECT url FROM `publicdata.samples.github_nested` LIMIT 100';

const SCHEMA = [
Expand Down Expand Up @@ -2390,3 +2412,7 @@ describe('BigQuery', () => {
}
}
});
};

runTests(true);
runTests(undefined);
Loading