Skip to content

parameterize BigQuery system tests for picosecond support#7975

Draft
danieljbruce wants to merge 1 commit intotry-reverting-commits-add-feature-flagsfrom
parameterize-bigquery-system-tests-picoseconds-4647787893340222599
Draft

parameterize BigQuery system tests for picosecond support#7975
danieljbruce wants to merge 1 commit intotry-reverting-commits-add-feature-flagsfrom
parameterize-bigquery-system-tests-picoseconds-4647787893340222599

Conversation

@danieljbruce
Copy link
Copy Markdown
Contributor

Parameterized BigQuery system tests to run twice: once with BIGQUERY_PICOSECOND_SUPPORT=true and once with it unset. Re-instantiates clients and resources in the before hook for proper configuration and preserves existing code indentation for a minimal PR diff.


PR created automatically by Jules for task 4647787893340222599 started by @danieljbruce

Wraps the BigQuery system tests in a parameterized function to run them
both with and without the BIGQUERY_PICOSECOND_SUPPORT environment
variable. Clients and resources are re-instantiated within a before hook
to ensure the library picks up the environment changes for each run.
The existing indentation is preserved to maintain a clean PR diff.

Co-authored-by: danieljbruce <8935272+danieljbruce@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant