Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion java-iam-policy/.repo-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
"repo": "googleapis/google-cloud-java",
"repo_short": "java-iam-policy",
"distribution_name": "com.google.cloud:google-iam-policy",
"api_id": "iam.googleapis.com",
"library_type": "GAPIC_AUTO",
"requires_billing": true,
"excluded_dependencies": "google-iam-policy",
Expand Down
2 changes: 1 addition & 1 deletion java-iam-policy/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ Java is a registered trademark of Oracle and/or its affiliates.
[code-of-conduct]: https://github.com/googleapis/google-cloud-java/blob/main/CODE_OF_CONDUCT.md#contributor-code-of-conduct
[license]: https://github.com/googleapis/google-cloud-java/blob/main/LICENSE
[enable-billing]: https://cloud.google.com/apis/docs/getting-started#enabling_billing
[enable-api]: https://console.cloud.google.com/flows/enableapi?apiid=iam.googleapis.com

[libraries-bom]: https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM
[shell_img]: https://gstatic.com/cloudssh/images/open-btn.png

Expand Down
12 changes: 6 additions & 6 deletions sdk-platform-java/gapic-generator-java/DEVELOPMENT.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,32 +54,32 @@ root of the repository (where you have WORKSPACE file for Bazel.)

```sh
# In the repository root directory
bazelisk test //... # integration tests
bazelisk test //sdk-platform-java/... # integration tests
```


- Run a single integration test for API like `Redis`, it generates Java source
code using the Java microgenerator and compares them with the goldens files
in `test/integration/goldens/redis`.
in `sdk-platform-java/test/integration/goldens/redis`.

```sh
# In the repository root directory
bazelisk test //test/integration:redis
bazelisk test //sdk-platform-java/test/integration:redis
```

- Update integration test golden files, for example `Redis`. This clobbers all the
files in `test/integration/goldens/redis`.
files in `sdk-platform-java/test/integration/goldens/redis`.

```sh
# In the repository root directory
bazelisk run //test/integration:update_redis
bazelisk run //sdk-platform-java/test/integration:update_redis
```

- To update all integration tests you can use this command:

```sh
# In the repository root directory
bazelisk run //test/integration:update_asset && bazelisk run //test/integration:update_credentials && bazelisk run //test/integration:update_iam && bazelisk run //test/integration:update_kms && bazelisk run //test/integration:update_pubsub && bazelisk run //test/integration:update_logging && bazelisk run //test/integration:update_redis && bazelisk run //test/integration:update_storage && bazelisk run //test/integration:update_library && bazelisk run //test/integration:update_compute && bazelisk run //test/integration:update_bigtable && bazelisk run //test/integration:update_apigeeconnect
bazelisk run //sdk-platform-java/test/integration:update_asset && bazelisk run //sdk-platform-java/test/integration:update_credentials && bazelisk run //sdk-platform-java/test/integration:update_iam && bazelisk run //sdk-platform-java/test/integration:update_kms && bazelisk run //sdk-platform-java/test/integration:update_pubsub && bazelisk run //sdk-platform-java/test/integration:update_logging && bazelisk run //sdk-platform-java/test/integration:update_redis && bazelisk run //sdk-platform-java/test/integration:update_storage && bazelisk run //sdk-platform-java/test/integration:update_library && bazelisk run //sdk-platform-java/test/integration:update_compute && bazelisk run //sdk-platform-java/test/integration:update_bigtable && bazelisk run //sdk-platform-java/test/integration:update_apigeeconnect
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The command to update all integration tests is extremely long, which hinders readability and makes it difficult to verify or modify the list of targets. Breaking the command into multiple lines would significantly improve the maintainability of this documentation.

Suggested change
bazelisk run //sdk-platform-java/test/integration:update_asset && bazelisk run //sdk-platform-java/test/integration:update_credentials && bazelisk run //sdk-platform-java/test/integration:update_iam && bazelisk run //sdk-platform-java/test/integration:update_kms && bazelisk run //sdk-platform-java/test/integration:update_pubsub && bazelisk run //sdk-platform-java/test/integration:update_logging && bazelisk run //sdk-platform-java/test/integration:update_redis && bazelisk run //sdk-platform-java/test/integration:update_storage && bazelisk run //sdk-platform-java/test/integration:update_library && bazelisk run //sdk-platform-java/test/integration:update_compute && bazelisk run //sdk-platform-java/test/integration:update_bigtable && bazelisk run //sdk-platform-java/test/integration:update_apigeeconnect
bazelisk run //sdk-platform-java/test/integration:update_asset && \
bazelisk run //sdk-platform-java/test/integration:update_credentials && \
bazelisk run //sdk-platform-java/test/integration:update_iam && \
bazelisk run //sdk-platform-java/test/integration:update_kms && \
bazelisk run //sdk-platform-java/test/integration:update_pubsub && \
bazelisk run //sdk-platform-java/test/integration:update_logging && \
bazelisk run //sdk-platform-java/test/integration:update_redis && \
bazelisk run //sdk-platform-java/test/integration:update_storage && \
bazelisk run //sdk-platform-java/test/integration:update_library && \
bazelisk run //sdk-platform-java/test/integration:update_compute && \
bazelisk run //sdk-platform-java/test/integration:update_bigtable && \
bazelisk run //sdk-platform-java/test/integration:update_apigeeconnect

```

## Running the Plugin under googleapis with local gapic-generator-java
Expand Down
Loading