docs: update bazel targets in DEVELOPMENT.md to point to sdk-platform-java#12844
Open
docs: update bazel targets in DEVELOPMENT.md to point to sdk-platform-java#12844
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the DEVELOPMENT.md file to reflect a directory structure change, specifically by prepending the sdk-platform-java/ prefix to Bazel targets and file paths. A review comment suggests improving the readability and maintainability of the documentation by breaking a long single-line command into multiple lines.
| ```sh | ||
| # In the repository root directory | ||
| bazelisk run //test/integration:update_asset && bazelisk run //test/integration:update_credentials && bazelisk run //test/integration:update_iam && bazelisk run //test/integration:update_kms && bazelisk run //test/integration:update_pubsub && bazelisk run //test/integration:update_logging && bazelisk run //test/integration:update_redis && bazelisk run //test/integration:update_storage && bazelisk run //test/integration:update_library && bazelisk run //test/integration:update_compute && bazelisk run //test/integration:update_bigtable && bazelisk run //test/integration:update_apigeeconnect | ||
| bazelisk run //sdk-platform-java/test/integration:update_asset && bazelisk run //sdk-platform-java/test/integration:update_credentials && bazelisk run //sdk-platform-java/test/integration:update_iam && bazelisk run //sdk-platform-java/test/integration:update_kms && bazelisk run //sdk-platform-java/test/integration:update_pubsub && bazelisk run //sdk-platform-java/test/integration:update_logging && bazelisk run //sdk-platform-java/test/integration:update_redis && bazelisk run //sdk-platform-java/test/integration:update_storage && bazelisk run //sdk-platform-java/test/integration:update_library && bazelisk run //sdk-platform-java/test/integration:update_compute && bazelisk run //sdk-platform-java/test/integration:update_bigtable && bazelisk run //sdk-platform-java/test/integration:update_apigeeconnect |
Contributor
There was a problem hiding this comment.
The command to update all integration tests is extremely long, which hinders readability and makes it difficult to verify or modify the list of targets. Breaking the command into multiple lines would significantly improve the maintainability of this documentation.
Suggested change
| bazelisk run //sdk-platform-java/test/integration:update_asset && bazelisk run //sdk-platform-java/test/integration:update_credentials && bazelisk run //sdk-platform-java/test/integration:update_iam && bazelisk run //sdk-platform-java/test/integration:update_kms && bazelisk run //sdk-platform-java/test/integration:update_pubsub && bazelisk run //sdk-platform-java/test/integration:update_logging && bazelisk run //sdk-platform-java/test/integration:update_redis && bazelisk run //sdk-platform-java/test/integration:update_storage && bazelisk run //sdk-platform-java/test/integration:update_library && bazelisk run //sdk-platform-java/test/integration:update_compute && bazelisk run //sdk-platform-java/test/integration:update_bigtable && bazelisk run //sdk-platform-java/test/integration:update_apigeeconnect | |
| bazelisk run //sdk-platform-java/test/integration:update_asset && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_credentials && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_iam && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_kms && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_pubsub && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_logging && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_redis && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_storage && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_library && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_compute && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_bigtable && \ | |
| bazelisk run //sdk-platform-java/test/integration:update_apigeeconnect |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the Bazel targets and paths in DEVELOPMENT.md to point to the sdk-platform-java subfolder, following the merge of sdk-platform-java into google-cloud-java.