Skip to content

refactor: move java-common-protos to top level #12839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chingor13 wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor: move java-common-protos to top level #12839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c73c84f
refactor: move iam-policy code to java-iam-policy folder
chingor13 Apr 17, 2026
abc30b4
chore: generate libraries at Fri Apr 17 18:32:33 UTC 2026
cloud-java-bot Apr 17, 2026
bf65641
refactor: move java-common-protos to top level
chingor13 Apr 17, 2026
17c415a
Merge branch 'main' into flatten-generated-modules
chingor13 Apr 17, 2026
66f7f67
chore: generate libraries at Fri Apr 17 21:27:26 UTC 2026
cloud-java-bot Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
24 changes: 23 additions & 1 deletion generation_config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3015,4 +3015,26 @@ libraries:
GAPICs:
- proto_path: google/cloud/workstations/v1
- proto_path: google/cloud/workstations/v1beta

- api_shortname: common-protos
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new common-protos entry is added at the end of the libraries list. However, this list appears to be maintained in alphabetical order by api_shortname. To maintain consistency and ensure the configuration remains easy to navigate, please move this entry to its correct alphabetical position.

name_pretty: Common Protos
product_documentation: https://github.com/googleapis/api-common-protos
api_description: Protobuf classes for Google's common protos.
release_level: stable
client_documentation: https://cloud.google.com/java/docs/reference/proto-google-common-protos/latest/history
distribution_name: com.google.api.grpc:proto-google-common-protos
excluded_dependencies: "proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent"
excluded_poms: "proto-google-common-protos-bom,proto-google-common-protos"
Comment on lines +3025 to +3026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The values for excluded_dependencies and excluded_poms in the common-protos entry are enclosed in double quotes. This is inconsistent with other entries in the file, which use plain strings. For consistency across the configuration file, please remove the unnecessary quotes.

  excluded_dependencies: proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent
  excluded_poms: proto-google-common-protos-bom,proto-google-common-protos

library_type: OTHER
GAPICs:
- proto_path: google/api
- proto_path: google/apps/card/v1
- proto_path: google/cloud
- proto_path: google/cloud/audit
- proto_path: google/cloud/location
- proto_path: google/geo/type
- proto_path: google/logging/type
- proto_path: google/longrunning
- proto_path: google/rpc
- proto_path: google/rpc/context
- proto_path: google/shopping/type
- proto_path: google/type
0 .../java-common-protos/.OwlBot-hermetic.yaml → java-common-protos/.OwlBot-hermetic.yaml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...va/java-common-protos/.repo-metadata.json → java-common-protos/.repo-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"release_level": "stable",
"transport": "grpc",
"language": "java",
"repo": "googleapis/sdk-platform-java",
"repo": "googleapis/google-cloud-java",
"repo_short": "java-common-protos",
"distribution_name": "com.google.api.grpc:proto-google-common-protos",
"library_type": "OTHER",
Expand Down
0 ...form-java/java-common-protos/CHANGELOG.md → java-common-protos/CHANGELOG.md
View file
Open in desktop
File renamed without changes.
0 ...latform-java/java-common-protos/README.md → java-common-protos/README.md
View file
Open in desktop
File renamed without changes.
0 ...-protos/grpc-google-common-protos/LICENSE → ...-protos/grpc-google-common-protos/LICENSE
View file
Open in desktop
File renamed without changes.
0 ...-protos/grpc-google-common-protos/pom.xml → ...-protos/grpc-google-common-protos/pom.xml
View file
Open in desktop
File renamed without changes.
0 .../google/cloud/location/LocationsGrpc.java → .../google/cloud/location/LocationsGrpc.java
View file
Open in desktop
File renamed without changes.
0 ...om/google/longrunning/OperationsGrpc.java → ...om/google/longrunning/OperationsGrpc.java
View file
Open in desktop
File renamed without changes.
0 ...latform-java/java-common-protos/owlbot.py → java-common-protos/owlbot.py
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion sdk-platform-java/java-common-protos/pom.xml → java-common-protos/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<groupId>com.google.api</groupId>
<artifactId>gapic-generator-java-pom-parent</artifactId>
<version>2.71.0</version><!-- {x-version-update:gapic-generator-java:current} -->
<relativePath>../gapic-generator-java-pom-parent</relativePath>
<relativePath>../sdk-platform-java/gapic-generator-java-pom-parent</relativePath>
</parent>

<developers>
Expand Down
0 ...protos/proto-google-common-protos/LICENSE → ...protos/proto-google-common-protos/LICENSE
View file
Open in desktop
File renamed without changes.
0 ...mmon-protos/clirr-ignored-differences.xml → ...mmon-protos/clirr-ignored-differences.xml
View file
Open in desktop
File renamed without changes.
0 ...protos/proto-google-common-protos/pom.xml → ...protos/proto-google-common-protos/pom.xml
View file
Open in desktop
File renamed without changes.
0 .../src/main/java/com/google/api/Advice.java → .../src/main/java/com/google/api/Advice.java
View file
Open in desktop
File renamed without changes.
0 .../java/com/google/api/AdviceOrBuilder.java → .../java/com/google/api/AdviceOrBuilder.java
View file
Open in desktop
File renamed without changes.
0 ...java/com/google/api/AnnotationsProto.java → ...java/com/google/api/AnnotationsProto.java
View file
Open in desktop
File renamed without changes.
0 ...c/main/java/com/google/api/AuthProto.java → ...c/main/java/com/google/api/AuthProto.java
View file
Open in desktop
File renamed without changes.
0 ...ain/java/com/google/api/AuthProvider.java → ...ain/java/com/google/api/AuthProvider.java
View file
Open in desktop
File renamed without changes.
0 ...com/google/api/AuthProviderOrBuilder.java → ...com/google/api/AuthProviderOrBuilder.java
View file
Open in desktop
File renamed without changes.
0 .../java/com/google/api/AuthRequirement.java → .../java/com/google/api/AuthRequirement.java
View file
Open in desktop
File renamed without changes.
0 .../google/api/AuthRequirementOrBuilder.java → .../google/api/AuthRequirementOrBuilder.java
View file
Open in desktop
File renamed without changes.
0 ...n/java/com/google/api/Authentication.java → ...n/java/com/google/api/Authentication.java
View file
Open in desktop
File renamed without changes.
0 ...m/google/api/AuthenticationOrBuilder.java → ...m/google/api/AuthenticationOrBuilder.java
View file
Open in desktop
File renamed without changes.
0 ...va/com/google/api/AuthenticationRule.java → ...va/com/google/api/AuthenticationRule.java
View file
Open in desktop
File renamed without changes.
0 ...ogle/api/AuthenticationRuleOrBuilder.java → ...ogle/api/AuthenticationRuleOrBuilder.java
View file
Open in desktop
File renamed without changes.
0 ...src/main/java/com/google/api/Backend.java → ...src/main/java/com/google/api/Backend.java
View file
Open in desktop
File renamed without changes.
0 ...java/com/google/api/BackendOrBuilder.java → ...java/com/google/api/BackendOrBuilder.java
View file
Open in desktop
File renamed without changes.
10 changes: 6 additions & 4 deletions ...ain/java/com/google/api/BackendProto.java → ...ain/java/com/google/api/BackendProto.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "\030google/api/backend.proto\022\n"
+ "google.api\"1\n"
+ "\007Backend\022&\n"
+ "\005rules\030\001 \003(\0132\027.google.api.BackendRule\"\262\004\n"
+ "\005rules\030\001 \003(\0132\027.google.api.BackendRule\"\321\004\n"
+ "\013BackendRule\022\020\n"
+ "\010selector\030\001 \001(\t\022\017\n"
+ "\007address\030\002 \001(\t\022\020\n"
Expand All @@ -78,7 +78,8 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "\014disable_auth\030\010 \001(\010H\000\022\020\n"
+ "\010protocol\030\t \001(\t\022^\n"
+ "\035overrides_by_request_protocol\030\n"
+ " \003(\01327.google.api.BackendRule.OverridesByRequestProtocolEntry\032Z\n"
+ " \003(\01327.google.api.BackendRule.OverridesByRequestProtocolEntry\022\035\n"
+ "\025load_balancing_policy\030\013 \001(\t\032Z\n"
+ "\037OverridesByRequestProtocolEntry\022\013\n"
+ "\003key\030\001 \001(\t\022&\n"
+ "\005value\030\002 \001(\0132\027.google.api.BackendRule:\0028\001\"e\n"
Expand All @@ -87,8 +88,8 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
+ "\020CONSTANT_ADDRESS\020\001\022\032\n"
+ "\026APPEND_PATH_TO_ADDRESS\020\002B\020\n"
+ "\016authenticationBn\n"
+ "\016com.google.apiB\014BackendProtoP\001ZEgoogle.golang.org/genproto/goo"
+ "gleapis/api/serviceconfig;serviceconfig\242\002\004GAPIb\006proto3"
+ "\016com.google.apiB\014BackendProtoP\001ZEgoogle.golang.org/genproto/googleapis/a"
+ "pi/serviceconfig;serviceconfig\242\002\004GAPIb\006proto3"
};
descriptor =
com.google.protobuf.Descriptors.FileDescriptor.internalBuildGeneratedFileFrom(
Expand All @@ -115,6 +116,7 @@ public static com.google.protobuf.Descriptors.FileDescriptor getDescriptor() {
"DisableAuth",
"Protocol",
"OverridesByRequestProtocol",
"LoadBalancingPolicy",
"Authentication",
});
internal_static_google_api_BackendRule_OverridesByRequestProtocolEntry_descriptor =
Expand Down
Loading
Loading