refactor: move java-common-protos to top level#12839
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the IAM library configuration to iam-policy, adds an api_id, and introduces a new common-protos library entry in generation_config.yaml. It also adjusts the parent POM relative path in java-common-protos/pom.xml. Feedback focuses on maintaining alphabetical order for library entries, updating the display name for the IAM Policy library for consistency, and ensuring consistent string formatting by removing unnecessary quotes in the configuration file.
| - proto_path: google/cloud/workstations/v1 | ||
| - proto_path: google/cloud/workstations/v1beta | ||
|
|
||
| - api_shortname: common-protos |
There was a problem hiding this comment.
The new common-protos entry is added at the end of the libraries list. However, this list appears to be maintained in alphabetical order by api_shortname. To maintain consistency and ensure the configuration remains easy to navigate, please move this entry to its correct alphabetical position.
| requires_billing: true | ||
| - api_shortname: iam | ||
| - api_shortname: iam-policy | ||
| name_pretty: IAM |
There was a problem hiding this comment.
The api_shortname has been updated to iam-policy and the distribution_name is com.google.cloud:google-iam-policy. To ensure consistency and clearly distinguish this library from the main IAM client library, the name_pretty should also be updated to IAM Policy.
name_pretty: IAM Policy| excluded_dependencies: "proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent" | ||
| excluded_poms: "proto-google-common-protos-bom,proto-google-common-protos" |
There was a problem hiding this comment.
The values for excluded_dependencies and excluded_poms in the common-protos entry are enclosed in double quotes. This is inconsistent with other entries in the file, which use plain strings. For consistency across the configuration file, please remove the unnecessary quotes.
excluded_dependencies: proto-google-common-protos,grpc-google-common-protos,proto-google-common-protos-parent
excluded_poms: proto-google-common-protos-bom,proto-google-common-protos2 participants
No description provided.