Skip to content

fix: handle error returns from fixture.Idx() and fixture.Packfile() #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
go-git-renovate wants to merge 2 commits into from
Closed

fix: handle error returns from fixture.Idx() and fixture.Packfile() #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f742cfb
build: Update github.com/go-git/go-git-fixtures/v5 digest to eda62fa
go-git-renovate[bot] Mar 28, 2026
cf09893
fix: handle multiple return values from fixture.Idx() and fixture.Pac…
Copilot Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion cmd/gogit/verify-pack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,17 @@ func openPack(path string) (billy.File, billy.File, error) {

fixture := f.One()

return fixture.Idx(), fixture.Packfile(), nil
idxFile, err := fixture.Idx()
if err != nil {
return nil, nil, fmt.Errorf("failed to open fixture index: %w", err)
}

packFile, err := fixture.Packfile()
if err != nil {
return nil, nil, fmt.Errorf("failed to open fixture packfile: %w", err)
}

return idxFile, packFile, nil
}

idxPath := path
Expand Down
4 changes: 2 additions & 2 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ go 1.24.0
toolchain go1.25.4

require (
github.com/go-git/go-billy/v6 v6.0.0-20260114122816-19306b749ecc
github.com/go-git/go-git-fixtures/v5 v5.1.2-0.20260207212403-7b71b9a390be
github.com/go-git/go-billy/v6 v6.0.0-20260226131633-45bd0956d66f
github.com/go-git/go-git-fixtures/v5 v5.1.2-0.20260328065819-eda62fa02f83
github.com/go-git/go-git/v6 v6.0.0-20260114124804-a8db3a6585a6
github.com/spf13/cobra v1.10.2
golang.org/x/crypto v0.48.0
Expand Down
8 changes: 4 additions & 4 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ github.com/gliderlabs/ssh v0.3.8 h1:a4YXD1V7xMF9g5nTkdfnja3Sxy1PVDCj1Zg4Wb8vY6c=
github.com/gliderlabs/ssh v0.3.8/go.mod h1:xYoytBv1sV0aL3CavoDuJIQNURXkkfPA/wxQ1pL1fAU=
github.com/go-git/gcfg/v2 v2.0.2 h1:MY5SIIfTGGEMhdA7d7JePuVVxtKL7Hp+ApGDJAJ7dpo=
github.com/go-git/gcfg/v2 v2.0.2/go.mod h1:/lv2NsxvhepuMrldsFilrgct6pxzpGdSRC13ydTLSLs=
github.com/go-git/go-billy/v6 v6.0.0-20260114122816-19306b749ecc h1:rhkjrnRkamkRC7woapp425E4CAH6RPcqsS9X8LA93IY=
github.com/go-git/go-billy/v6 v6.0.0-20260114122816-19306b749ecc/go.mod h1:X1oe0Z2qMsa9hkar3AAPuL9hu4Mi3ztXEjdqRhr6fcc=
github.com/go-git/go-git-fixtures/v5 v5.1.2-0.20260207212403-7b71b9a390be h1:99rlepX9pwoqZQ0AzdJLRPinQLZ9QdkOScfkhY/GHYA=
github.com/go-git/go-git-fixtures/v5 v5.1.2-0.20260207212403-7b71b9a390be/go.mod h1:xKt0pNHST9tYHvbiLxSY27CQWFwgIxBJuDrOE0JvbZw=
github.com/go-git/go-billy/v6 v6.0.0-20260226131633-45bd0956d66f h1:Uvbx7nITO3Sd1GdXarX0TbyYmOaSNIJP0mm4LocEyyA=
github.com/go-git/go-billy/v6 v6.0.0-20260226131633-45bd0956d66f/go.mod h1:ZW9JC5gionMP1kv5uiaOaV23q0FFmNrVOV8VW+y/acc=
github.com/go-git/go-git-fixtures/v5 v5.1.2-0.20260328065819-eda62fa02f83 h1:it9grfcwKdquCxdiX9YauP7FGZIhjA7X0a/Za36TqVs=
github.com/go-git/go-git-fixtures/v5 v5.1.2-0.20260328065819-eda62fa02f83/go.mod h1:YvXSvVfFPFrsP+e92xpajmPzlA7kPhhaLkwkve57UVk=
github.com/go-git/go-git/v6 v6.0.0-20260114124804-a8db3a6585a6 h1:Yo1MlE8LpvD0pr7mZ04b6hKZKQcPvLrQFgyY1jNMEyU=
github.com/go-git/go-git/v6 v6.0.0-20260114124804-a8db3a6585a6/go.mod h1:enMzPHv+9hL4B7tH7OJGQKNzCkMzXovUoaiXfsLF7Xs=
github.com/golang/groupcache v0.0.0-20241129210726-2c02b8208cf8 h1:f+oWsMOmNPc8JmEHVZIycC7hBoQxHH9pNKQORJNozsQ=
Expand Down
Loading