Skip to content

fix: handle error returns from fixture.Idx() and fixture.Packfile()#42

Closed
go-git-renovate[bot] wants to merge 2 commits intomainfrom
renovate/go-git
Closed

fix: handle error returns from fixture.Idx() and fixture.Packfile()#42
go-git-renovate[bot] wants to merge 2 commits intomainfrom
renovate/go-git

Conversation

@go-git-renovate
Copy link
Copy Markdown
Contributor

@go-git-renovate go-git-renovate bot commented Mar 28, 2026

The go-git-fixtures digest bump changed fixture.Idx() and fixture.Packfile() to return (billy.File, error), breaking the build — both were used in single-value context in verify-pack.go.

Changes

  • cmd/gogit/verify-pack.go: Destructure both return values and propagate errors for fixture.Idx() and fixture.Packfile()
// Before
return fixture.Idx(), fixture.Packfile(), nil

// After
idxFile, err := fixture.Idx()
if err != nil {
    return nil, nil, fmt.Errorf("failed to open fixture index: %w", err)
}

packFile, err := fixture.Packfile()
if err != nil {
    return nil, nil, fmt.Errorf("failed to open fixture packfile: %w", err)
}

return idxFile, packFile, nil

📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.

@pjbgf
Copy link
Copy Markdown
Member

pjbgf commented Mar 28, 2026

@copilot fix the build errors by updating the calls to the new signatures.

@go-git-renovate go-git-renovate bot changed the title build: Update go-git build: Update github.com/go-git/go-git-fixtures/v5 digest to eda62fa Mar 28, 2026
@go-git-renovate
Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 1 additional dependency was updated

Details:

Package Change
github.com/go-git/go-billy/v6 v6.0.0-20260114122816-19306b749ecc -> v6.0.0-20260226131633-45bd0956d66f

Copilot AI changed the title build: Update github.com/go-git/go-git-fixtures/v5 digest to eda62fa fix: handle error returns from fixture.Idx() and fixture.Packfile() Mar 28, 2026
@pjbgf pjbgf closed this Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants