Skip to content

merge-base, ls-remote, ls-tree: fix error message formatting #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mdferdousalam wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −5
Open

merge-base, ls-remote, ls-tree: fix error message formatting #2053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builtin/ls-remote.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ int cmd_ls_remote(int argc,
if (!remote) {
if (dest)
die("bad repository '%s'", dest);
die("No remote configured to list refs from.");
die("no remote configured to list refs from");
}

if (get_url) {
Expand Down
2 changes: 1 addition & 1 deletion builtin/ls-tree.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ int cmd_ls_tree(int argc,
usage_with_options(ls_tree_usage, ls_tree_options);
if (repo_get_oid_with_flags(the_repository, argv[0], &oid,
GET_OID_HASH_ANY))
die("Not a valid object name %s", argv[0]);
die("not a valid object name %s", argv[0]);

/*
* show_recursive() rolls its own matching code and is
Expand Down
6 changes: 3 additions & 3 deletions builtin/merge-base.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ static struct commit *get_commit_reference(const char *arg)
struct commit *r;

if (repo_get_oid(the_repository, arg, &revkey))
die("Not a valid object name %s", arg);
die("not a valid object name %s", arg);
r = lookup_commit_reference(the_repository, &revkey);
if (!r)
die("Not a valid commit name %s", arg);
die("not a valid commit name %s", arg);

return r;
}
Expand Down Expand Up @@ -131,7 +131,7 @@ static int handle_fork_point(int argc, const char **argv)

commitname = (argc == 2) ? argv[1] : "HEAD";
if (repo_get_oid(the_repository, commitname, &oid))
die("Not a valid object name: '%s'", commitname);
die("not a valid object name: '%s'", commitname);

derived = lookup_commit_reference(the_repository, &oid);

Expand Down
Loading