merge-base, ls-remote, ls-tree: fix error message formatting#2053
Open
mdferdousalam wants to merge 1 commit intogitgitgadget:masterfrom
Open
merge-base, ls-remote, ls-tree: fix error message formatting#2053mdferdousalam wants to merge 1 commit intogitgitgadget:masterfrom
mdferdousalam wants to merge 1 commit intogitgitgadget:masterfrom
Conversation
Author
|
/submit |
|
Submitted as pull.2053.git.1771836979176.gitgitgadget@gmail.com To fetch this version into To fetch this version to local tag |
Author
|
/submit |
|
Error: 5c153a6 was already submitted |
The CodingGuidelines state that error messages should not begin with a capital letter and should not end with a full stop. Fix the die() messages in builtin/merge-base.c, builtin/ls-remote.c, and builtin/ls-tree.c that violate these rules. Signed-off-by: Md Ferdous Alam <mdferdousalam1989@yahoo.com>
mdferdousalam
force-pushed
the
fix-error-messages-misc
branch
from
5c153a6 to
5f8c882
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize error messages in builtin/merge-base.c, builtin/ls-remote.c,
and builtin/ls-tree.c to follow Git's coding guidelines: begin messages
with a lowercase letter and remove trailing periods.
This addresses #635
Signed-off-by: mdferdousalam mdferdousalam1989@yahoo.com