Skip to content

test(remix-hydrogen): Fix flaky navigation transaction test #21535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Jun 15, 2026
Merged

test(remix-hydrogen): Fix flaky navigation transaction test #21535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions dev-packages/e2e-tests/test-applications/remix-hydrogen/tests/client-transactions.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,23 @@ test('Sends a pageload transaction to Sentry', async ({ page }) => {
});

test('Sends a navigation transaction to Sentry', async ({ page }) => {
// Wait for the initial pageload transaction first. This ensures the client SDK and
// Remix router are fully hydrated before we click the link. Clicking before hydration
// completes makes the `<Link>` behave like a plain anchor, triggering a full page
// navigation (a `pageload` transaction) instead of a client-side `navigation` one,
// which makes this test flaky.
const pageloadTransactionPromise = waitForTransaction('remix-hydrogen', transactionEvent => {
return transactionEvent.contexts?.trace?.op === 'pageload' && transactionEvent.transaction === '/';
});

const transactionPromise = waitForTransaction('remix-hydrogen', transactionEvent => {
return transactionEvent.contexts?.trace?.op === 'navigation' && transactionEvent.transaction === '/user/:id';
});

await page.goto('/');

await pageloadTransactionPromise;

const linkElement = page.locator('id=navigation');
await linkElement.click();

Expand Down
Loading