test(remix-hydrogen): Fix flaky navigation transaction test#21535
Merged
Conversation
…ransaction test Fixes #21198 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mydea
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the flaky
[chromium] › tests/client-transactions.test.ts:16:1 › Sends a navigation transaction to SentryE2E test in theremix-hydrogentest application.Root cause
The test does
page.goto('/')and then immediately clicks the#navigation<Link>, expecting a client-sidenavigationtransaction to/user/:id.If Remix has not finished hydrating when the click fires, the
<Link>behaves like a plain<a href="/user/5">and the browser performs a full page navigation. That produces apageloadtransaction for/user/:idrather than anavigationtransaction. Since the test only resolves onop === 'navigation', thewaitForTransactionpromise never settles and the test times out — the source of the flake.Fix
Wait for the initial
pageloadtransaction (op === 'pageload',transaction === '/') to be sent before clicking the link. By the time that transaction is emitted, the client SDK and Remix router are hydrated, so the click reliably produces a client-sidenavigationtransaction. This mirrors the existingpageloadPromisepattern already used inreact-router-7-lazy-routes/tests/transactions.test.ts.All existing assertions are preserved unchanged.
Fixes #21198