chore(deps-dev): bump jsdom from 21.1.2 to 28.1.0#19428
chore(deps-dev): bump jsdom from 21.1.2 to 28.1.0#19428dependabot[bot] wants to merge 1 commit intodevelopfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "es-check": "^7.2.1", | ||
| "eslint": "8.57.0", | ||
| "jsdom": "^21.1.2", | ||
| "jsdom": "^28.1.0", |
There was a problem hiding this comment.
Outdated @types/jsdom incompatible with jsdom 28
Medium Severity
The jsdom dependency is bumped to ^28.1.0 but @types/jsdom remains at ^21.1.6. The compatible types package for jsdom 28 is @types/jsdom@27.0.0. This version mismatch means the TypeScript type definitions won't reflect the actual jsdom 28 API, particularly the overhauled resource loading options and other breaking changes across seven major versions.
Additional Locations (1)
| "es-check": "^7.2.1", | ||
| "eslint": "8.57.0", | ||
| "jsdom": "^21.1.2", | ||
| "jsdom": "^28.1.0", |
There was a problem hiding this comment.
Removed resources: 'usable' option breaks test
High Severity
Bumping jsdom to v28 breaks the test in packages/browser/test/utils/lazyLoadIntegration.test.ts which uses resources: 'usable' in the JSDOM constructor. jsdom v28.0.0 completely overhauled resource loading customization and removed the 'usable' string option, replacing it with a new API. This test will fail at runtime after this upgrade.
|
@dependabot rebase |
Bumps [jsdom](https://github.com/jsdom/jsdom) from 21.1.2 to 28.1.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@21.1.2...28.1.0) --- updated-dependencies: - dependency-name: jsdom dependency-version: 28.1.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
33710cf to
a6ba1d3
Compare
|
I don't see a reason to bump this |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |


Bumps jsdom from 21.1.2 to 28.1.0.
Release notes
Sourced from jsdom's releases.
... (truncated)
Changelog
Sourced from jsdom's changelog.
... (truncated)
Commits
12949b5Version 28.1.0ce4c58fApply CSS specificity when computing styles7ed55a0Skip single-byte-decoder encoding tests on Node 20f3b1973Generalize node version conditions in test expectations853c596Rewrite getElementById ID caching for tree-order correctness5fbfde6Fix potential sync XHR worker hang from unhandled dispatch errors82df38fCache the root node for document-connected treesed7c5c0Add documentation comment to create-event-accessor.jsb4562e9Simplify Window.js installEventHandlers7da340fCentralize "determine the target of an event handler"Install script changes
This version modifies
preparescript that runs during installation. Review the package contents before updating.Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)