Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
"downlevel-dts": "~0.11.0",
"es-check": "^7.2.1",
"eslint": "8.57.0",
"jsdom": "^21.1.2",
"jsdom": "^28.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated @types/jsdom incompatible with jsdom 28

Medium Severity

The jsdom dependency is bumped to ^28.1.0 but @types/jsdom remains at ^21.1.6. The compatible types package for jsdom 28 is @types/jsdom@27.0.0. This version mismatch means the TypeScript type definitions won't reflect the actual jsdom 28 API, particularly the overhauled resource loading options and other breaking changes across seven major versions.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed resources: 'usable' option breaks test

High Severity

Bumping jsdom to v28 breaks the test in packages/browser/test/utils/lazyLoadIntegration.test.ts which uses resources: 'usable' in the JSDOM constructor. jsdom v28.0.0 completely overhauled resource loading customization and removed the 'usable' string option, replacing it with a new API. This test will fail at runtime after this upgrade.

Fix in Cursor Fix in Web

"nx": "22.5.0",
"madge": "8.0.0",
"nodemon": "^3.1.10",
Expand Down
Loading
Loading