Skip to content

chore(deps-dev): bump ember-cli from 4.12.3 to 6.10.0 #19088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
Closed

chore(deps-dev): bump ember-cli from 4.12.3 to 6.10.0 #19088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ember/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"@types/rsvp": "~4.0.9",
"babel-eslint": "~10.1.0",
"broccoli-asset-rev": "~3.0.0",
"ember-cli": "~4.12.3",
"ember-cli": "~6.10.0",
Copy link

@cursor cursor bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node version mismatch between package engines and ember-cli requirement

Medium Severity

The package's engines field declares "node": ">=18", but ember-cli 6.10.0 requires Node.js v20.19.0 or higher according to the release notes. This mismatch means developers or CI systems using Node 18 or early Node 20 versions will encounter failures when trying to run development scripts, build, or test the package. The engines field is now inconsistent with the actual minimum Node version required by the dev dependencies.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link

@sentry sentry bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The ember-cli dev dependency is bumped to ~6.10.0, but the test suite runs against older versions, leaving the usage of the private _findHost() API untested.
Severity: MEDIUM

Suggested Fix

Update the test configurations, particularly for the dummy app (packages/ember/tests/dummy/) and E2E tests, to use ember-cli@~6.10.0. This will ensure the test suite validates the addon's compatibility with the newly specified ember-cli version and catches potential breakages related to private API usage like _findHost().

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/ember/package.json#L63

Potential issue: The `ember-cli` dev dependency has been updated to `~6.10.0`, but the
project's test suites are configured to run against older versions (`4.8.0` and
`5.8.0`). The addon's code at `packages/ember/index.js` relies on `this._findHost()`, a
private API from `ember-cli`. Because the tests do not run against version `6.10.0`,
there is no validation that this private API still exists or functions as expected. This
creates a significant risk that the addon will fail at runtime for users who have
`ember-cli` v6.10.0 or later installed in their projects.

Did we get this right? 👍 / 👎 to inform future reviews.

"ember-cli-dependency-checker": "~3.3.2",
"ember-cli-inject-live-reload": "~2.1.0",
"ember-cli-terser": "~4.0.2",
Expand Down
Loading
Loading