chore(deps-dev): bump ember-cli from 4.12.3 to 6.10.0 #19088
Conversation
dependabot
bot
added
dependencies
Bumps [ember-cli](https://github.com/ember-cli/ember-cli) from 4.12.3 to 6.10.0. - [Release notes](https://github.com/ember-cli/ember-cli/releases) - [Changelog](https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md) - [Commits](https://github.com/ember-cli/ember-cli/commits) --- updated-dependencies: - dependency-name: ember-cli dependency-version: 6.10.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/ember-cli-6.10.0
branch
from
ba25799 to
0b9d4a6
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| "babel-eslint": "~10.1.0", | ||
| "broccoli-asset-rev": "~3.0.0", | ||
| "ember-cli": "~4.12.3", | ||
| "ember-cli": "~6.10.0", |
There was a problem hiding this comment.
Node version mismatch between package engines and ember-cli requirement
Medium Severity
The package's engines field declares "node": ">=18", but ember-cli 6.10.0 requires Node.js v20.19.0 or higher according to the release notes. This mismatch means developers or CI systems using Node 18 or early Node 20 versions will encounter failures when trying to run development scripts, build, or test the package. The engines field is now inconsistent with the actual minimum Node version required by the dev dependencies.
Additional Locations (1)
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| "babel-eslint": "~10.1.0", | ||
| "broccoli-asset-rev": "~3.0.0", | ||
| "ember-cli": "~4.12.3", | ||
| "ember-cli": "~6.10.0", |
There was a problem hiding this comment.
Bug: The ember-cli dev dependency is bumped to ~6.10.0, but the test suite runs against older versions, leaving the usage of the private _findHost() API untested.
Severity: MEDIUM
Suggested Fix
Update the test configurations, particularly for the dummy app (packages/ember/tests/dummy/) and E2E tests, to use ember-cli@~6.10.0. This will ensure the test suite validates the addon's compatibility with the newly specified ember-cli version and catches potential breakages related to private API usage like _findHost().
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/ember/package.json#L63
Potential issue: The `ember-cli` dev dependency has been updated to `~6.10.0`, but the
project's test suites are configured to run against older versions (`4.8.0` and
`5.8.0`). The addon's code at `packages/ember/index.js` relies on `this._findHost()`, a
private API from `ember-cli`. Because the tests do not run against version `6.10.0`,
there is no validation that this private API still exists or functions as expected. This
creates a significant risk that the addon will fail at runtime for users who have
`ember-cli` v6.10.0 or later installed in their projects.
Did we get this right? 👍 / 👎 to inform future reviews.
|
This can't be done as ember requires Node v20+, while we are still support v18 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
|
@dependabot ignore this major version |
|
OK, I won't notify you about version 6.x.x again, unless you re-open this PR. |
1 participant
Bumps ember-cli from 4.12.3 to 6.10.0.
Release notes
Sourced from ember-cli's releases.
... (truncated)
Changelog
Sourced from ember-cli's changelog.
... (truncated)
Commits
Maintainer changes
This version was pushed to npm by real_ate, a new releaser for ember-cli since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)