Skip to content

[Repo Assist] Fix FS1182 compiler warning in JsonSchema.parseSchemaFromTextReader #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[Repo Assist] Fix FS1182 compiler warning in JsonSchema.parseSchemaFromTextReader #1763

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
04bed46
Fix FS1182 compiler warning: mark resolutionFolder as intentionally u…
github-actions[bot] Apr 26, 2026
bb375ac
ci: trigger checks
github-actions[bot] Apr 26, 2026
4959745
Merge branch 'main' into repo-assist/fix-jsonschema-unused-resolution…
dsyme May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/FSharp.Data.Json.Core/JsonSchema.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,10 @@ module JsonSchema =
let parseSchemaFromString (schemaString: string) =
JsonValue.Parse(schemaString) |> parseSchema

/// Parse a JSON Schema from a TextReader
let parseSchemaFromTextReader (resolutionFolder: string) (reader: System.IO.TextReader) =
/// Parse a JSON Schema from a TextReader.
/// The <c>resolutionFolder</c> parameter is reserved for future <c>$ref</c> resolution support
/// and is not currently used; JSON Schema <c>$ref</c> resolution is not yet implemented.
let parseSchemaFromTextReader (_resolutionFolder: string) (reader: System.IO.TextReader) =
let schemaString = reader.ReadToEnd()
parseSchemaFromString schemaString

Expand Down
Loading