[Repo Assist] Fix FS1182 compiler warning in JsonSchema.parseSchemaFromTextReader#1763
Conversation
…nused The resolutionFolder parameter in JsonSchema.parseSchemaFromTextReader is a placeholder for future JSON Schema $ref resolution support (analogous to the XML provider which uses this parameter for XSD $ref resolution). Since $ref resolution is not yet implemented for JSON Schema, the parameter is currently unused, generating a FS1182 compiler warning. Prefix it with _ to indicate it is intentionally unused and suppress the warning, while preserving the future-use intent via the doc comment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…-folder-2026-04-26-bafa3f440e2e03d1
|
🤖 This is an automated response from Repo Assist. Checking in on the Windows CI failure: I've reviewed the build logs for the failing The A maintainer can safely re-run the failed Windows job to get a green checkmark, or simply approve and merge given the Ubuntu build is passing and the change is minimal.
|
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Fixes a pre-existing
FS1182compiler warning insrc/FSharp.Data.Json.Core/JsonSchema.fs:Root Cause
JsonSchema.parseSchemaFromTextReaderaccepts aresolutionFolder: stringparameter as a placeholder for future JSON Schema$refresolution support — analogous to how the XML provider uses this parameter for XSD$refresolution. Since JSON Schema$refresolution is not yet implemented, the parameter is currently unused, which triggers a FS1182 warning.Fix
Renamed the parameter from
resolutionFolderto_resolutionFolderto signal it is intentionally unused (the conventional F# idiom), and expanded the doc comment to explain the placeholder intent.No behaviour change — the call site in
src/FSharp.Data/Runtime.fspasses""and continues to work correctly.Test Status
dotnet build src/FSharp.Data.Json.Core/— Build succeeded, no FS1182 warningNU1902vulnerability error (OpenTelemetry.Api 1.15.0) on this branch — addressed separately in the OpenTelemetry fix PR