Skip to content

Update test_duration in parallel testsuite #26804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dschuff wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −0
Open

Update test_duration in parallel testsuite #26804

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions test/parallel_testsuite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ def run_test(args):
result._mirrorOutput = False
finally:
result.elapsed = time.perf_counter() - start_time
result.test_duration = result.elapsed
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How as this broken exactly?

Do we still need result.elapsed?

I notice we have an addDuration on the result here.. is that use called? Should we call it here?

Copy link
Copy Markdown
Member Author

@dschuff dschuff Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently when run on CI the result looks like Total core time: 0.000s. Wallclock time: 551.544s. Parallelization: 0.00x., i.e. the core time is always 0.
I don't know if we need result.elapsed or not.
addDuration() isn't called anywhere in our code AFAICS.
Interestingly this is not an issue locally on my cloudtop, it only seems to be broken on CI. I guess it must have something to do with the unittest library on the system?

Copy link
Copy Markdown
Collaborator

@juj juj Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a bit curious. On my CI, http://clbri.com:8010/#/builders/11/builds/1486 , I do fix all pythons via pyenv to Python 3.12.3, and there I do see appropriate numbers..

Total core time: 9775.613s. Wallclock time: 116.031s. Parallelization: 84.25x.

The start of the run should have that "info dump", that should print the python version, in case that might be meaningful.

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably something to do with CI=1 which triggers the XML test runner... which maybe doesn't call addDuration() in the same way?

Copy link
Copy Markdown
Member Author

@dschuff dschuff Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that too, except when I run it locally even with CI=1 it still works.

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF!


# Before attempting to delete the tmp dir make sure the current
# working directory is not within it.
Expand Down
Loading