Update test_duration in parallel testsuite#26804
Update test_duration in parallel testsuite#26804dschuff wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
This makes the "total core time" statistic correct on CI.
| result._mirrorOutput = False | ||
| finally: | ||
| result.elapsed = time.perf_counter() - start_time | ||
| result.test_duration = result.elapsed |
There was a problem hiding this comment.
How as this broken exactly?
Do we still need result.elapsed?
I notice we have an addDuration on the result here.. is that use called? Should we call it here?
There was a problem hiding this comment.
Currently when run on CI the result looks like Total core time: 0.000s. Wallclock time: 551.544s. Parallelization: 0.00x., i.e. the core time is always 0.
I don't know if we need result.elapsed or not.
addDuration() isn't called anywhere in our code AFAICS.
Interestingly this is not an issue locally on my cloudtop, it only seems to be broken on CI. I guess it must have something to do with the unittest library on the system?
There was a problem hiding this comment.
That is a bit curious. On my CI, http://clbri.com:8010/#/builders/11/builds/1486 , I do fix all pythons via pyenv to Python 3.12.3, and there I do see appropriate numbers..
Total core time: 9775.613s. Wallclock time: 116.031s. Parallelization: 84.25x.
The start of the run should have that "info dump", that should print the python version, in case that might be meaningful.
There was a problem hiding this comment.
This is probably something to do with CI=1 which triggers the XML test runner... which maybe doesn't call addDuration() in the same way?
There was a problem hiding this comment.
I thought that too, except when I run it locally even with CI=1 it still works.
3 participants
This makes the "total core time" statistic correct on CI.