Fix raise_on_missing_only raising on non-matching paths with colons#1298
Merged
josevalim merged 2 commits intoelixir-plug:mainfrom Feb 23, 2026
Merged
Fix raise_on_missing_only raising on non-matching paths with colons#1298josevalim merged 2 commits intoelixir-plug:mainfrom
raise_on_missing_only raising on non-matching paths with colons#1298josevalim merged 2 commits intoelixir-plug:mainfrom
Conversation
When `Plug.Static` is mounted at `/` with `raise_on_missing_only: true`, application routes containing colons (e.g. `/app/resource:id`) would i raise `InvalidPathError` because `invalid_path?` ran before the file existence check. This fix splits the catch-all status branch into explicit `:allowed` and `:raise` clauses so that `:raise` only fires when a valid path resolves to a real file on disk.
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Plug.Staticis mounted at/withraise_on_missing_only: true, application routes containing colons (e.g./app/resource:id) would raiseInvalidPathErrorbecauseinvalid_path?ran before the file existence check.This fix splits the catch-all status branch into explicit
:allowedand:raiseclauses so that:raiseonly fires when a valid path resolves to a real file on disk.