examples: Fix DC component in Ricker source#2743
examples: Fix DC component in Ricker source#2743ziyiyin97 wants to merge 1 commit intodevitocodes:mainfrom
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
mloubout
left a comment
There was a problem hiding this comment.
Well no that fix should go directly into the Rocker definition so that it's always correct by default.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2743 +/- ##
==========================================
- Coverage 83.07% 78.68% -4.39%
==========================================
Files 248 248
Lines 50623 50624 +1
Branches 4460 4460
==========================================
- Hits 42053 39832 -2221
- Misses 7808 9975 +2167
- Partials 762 817 +55
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Forcing the Ricker source to be zero-mean will lead to resampling failures. I guess we can make |
|
What do you mean resampling failures ? |
|
The test_resample.py failed |
|
Right because the mean correction gonna be slightly different. I would probably just patc the test adding some tolerance rather than adding an extra argument |
05b8148 to
8913c3e
Compare
|
Yes I raised the tolerance of the resampling test. |
c6e66f1 to
0ee1e7a
Compare
No description provided.