Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2770 +/- ##
===========================================
- Coverage 83.04% 53.24% -29.81%
===========================================
Files 248 248
Lines 50469 50511 +42
Branches 4440 4452 +12
===========================================
- Hits 41913 26895 -15018
- Misses 7795 22640 +14845
- Partials 761 976 +215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mloubout
left a comment
There was a problem hiding this comment.
Looks like a very nice cleanup.
Could you add a TODO statement to add missing "standard" ones like Ormsby, Klauder,
|
Also see ##2743, there is a tiny discretization issue that makes the discrete wavelet non-zero mean, which can be problematic. |
In response to being told to create the
examples.RickerSourceobject, whenever I redefined it as a function.