🤖 refactor: remove workflow agentType option#3618
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc3557aee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ThomasK33
force-pushed
the
refactor/remove-workflow-agenttype
branch
from
bc3557a to
4194f48
Compare
|
@codex review Addressed the replay concern by rejecting |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4194f48cda
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Stop accepting the legacy workflow agentType alias and require workflow authors to use agentId. --- _Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `$2.84`_ <!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=2.84 -->
ThomasK33
force-pushed
the
refactor/remove-workflow-agenttype
branch
from
4194f48 to
a30e675
Compare
|
@codex review Addressed the current-schema replay concern by adding a new-run marker: fresh runs reject |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Remove the legacy
agentTypeworkflow-agent option so workflow authors must useagentIdconsistently.Background
The workflow authoring skill still advertised
legacy agentTypeas an optional alias. This removes the alias from new workflow runs to avoid two names for the same workflow-agent selector.Implementation
agent(..., { agentType: ... })calls with a clear error directing authors toagentId.agentType, including current-schema runs created before this change.agentId,model, andthinkingnormalization unchanged.agentIdonly.Validation
bun test src/node/services/workflows/WorkflowRunner.test.tsbun test src/node/services/workflows/WorkflowRunStore.test.tsmake typecheckMUX_ESLINT_CONCURRENCY=1 make lintmake fmt-checkmake static-checkgit diff --checkRisks
Low. New workflow runs intentionally fail on the legacy
agentTypealias, while existing persisted runs keep enough compatibility to replay or resume their original source snapshots.Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:$2.84