🤖 refactor: auto-cleanup

[mux-bot]

Summary

Long-lived auto-cleanup PR maintained by the Auto-Cleanup Agent. Each pass lands at most one extremely low-risk, behavior-preserving cleanup drawn from recently merged main activity, then advances the checkpoint below. The prior long-lived PR (#3589) merged into main; this is its successor on a fresh auto-cleanup branch.

Auto-cleanup checkpoint: 34f8360

This PR currently contains three accumulated cleanups against main:

1. src/node/services/taskService.ts — dedupe queued-message foreground backgrounding into a private helper.
2. src/node/services/workflows/workflowScriptResolver.ts — reuse the SKILL_SCRIPT_PATH_PREFIX constant for canonical-path construction.
3. src/node/services/workflows/WorkflowTaskServiceAdapter.ts — extract the duplicated agent-task creation arg shape into a shared WorkflowTaskCreateArgs type.

This pass

Considered the three new commits on main since the prior checkpoint:

• 🤖 feat: default workflow agents to exec #3611 (feat: default workflow agents to exec)
• 🤖 fix: improve heartbeat modal layout #3612 (fix: improve heartbeat modal layout)
• 🤖 fix: hide placeholder workflow report buttons #3609 (fix: hide placeholder workflow report buttons)

WorkflowTaskServiceLike (in WorkflowTaskServiceAdapter.ts) declared the agent-task creation argument object twice — once inline in create(args: { ... }) and again inside createMany?(args: Array<{ ... }>) — as byte-identical 10-field shapes (including a nested workflowTask object). #3611 added the onRefusal field to both copies, which is exactly the drift risk this duplication invites.

Landed one behavior-preserving dedup: extracted a named WorkflowTaskCreateArgs interface and referenced it from both create and createMany, giving the agent-task creation shape a single source of truth.

Behavior-preserving:

• Pure type-level refactor: the extracted interface is structurally identical to the two inline shapes, so create/createMany signatures are unchanged. buildCreateArgs continues to satisfy Parameters<WorkflowTaskServiceLike["create"]>[0].
• No runtime code, control flow, or call semantics change.

Prior pass — workflowScriptResolver SKILL_SCRIPT_PATH_PREFIX reuse

In workflowScriptResolver.ts, the skill:// prefix is named by the module-level constant SKILL_SCRIPT_PATH_PREFIX and used when parsing incoming skill:// paths, but the two canonical-path builders re-spelled the literal `skill://${...}` instead of reusing the constant. Both builders now interpolate ${SKILL_SCRIPT_PATH_PREFIX} so the prefix has a single source of truth. Behavior-preserving: SKILL_SCRIPT_PATH_PREFIX is exactly "skill://", so the interpolation is byte-identical.

Prior pass — taskService queued-message dedup

Considered #3605 (fix: background foreground waits for prequeued messages), which open-coded the same queued-message guard at two TaskService wait-registration sites (waitForWorkspaceTurn and the task-await path). Both sites now delegate to a single private helper backgroundForegroundWaitIfQueued(shouldBackgroundOnQueuedMessage, requestingWorkspaceId) placed next to backgroundForegroundWaitsForWorkspace. Behavior-preserving: the helper folds in the requestingWorkspaceId truthiness guard (always true at the workspace-turn site; a verbatim match at the task-await site), and the pushed call is unchanged.

Validation

• make static-check passes locally for the touched code: ESLint, both TypeScript configs (tsconfig + tsconfig.main.json), and Prettier are green. The only non-passing step is fmt-shell-check, which fails solely because the shfmt binary is not installed in this environment; no shell files are touched by any change.

Risks

Minimal. All changes are pure local extractions/constant reuse within a single file each; no logic, types, or call semantics change. The latest pass is a type-only dedup with no runtime effect.

---

Generated with mux • Model: anthropic:claude-opus-4-8 • Thinking: xhigh

[mux-bot]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.

[mux-bot]

@codex review

This pass adds one behavior-preserving cleanup: in workflowScriptResolver.ts, the two canonical-path builders now reuse the existing SKILL_SCRIPT_PATH_PREFIX constant instead of re-spelling the skill:// literal. The constant value is identical, so the constructed strings are byte-identical. No logic, type, or call-semantics changes.

[mux-bot]

@codex review

[chatgpt-codex-connector]

To use Codex here, create a Codex account and connect to github.