🤖 ci: cache Playwright browsers on macOS#3616
Merged
Merged
Conversation
---
_Generated with `mux` • Model: `openai:gpt-5.5` • Thinking: `xhigh` • Cost: `3442216{MUX_COSTS_USD:-unknown}`_
<!-- mux-attribution: model=openai:gpt-5.5 thinking=xhigh costs=4.67 -->
Member
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cache Playwright browser installs on the correct OS-specific paths and bound the shared setup step so CI fails fast if a browser download stalls.
Background
The macOS E2E job on PR #3610 got stuck inside
setup-playwrightafter Chromium reached 100%. The existing cache path only covered Linux (~/.cache/ms-playwright), so macOS runners redownloaded browsers into~/Library/Caches/ms-playwrighton every cache miss instead of saving/restoring that directory.Implementation
.github/actions/setup-playwright.runner.archto the Playwright cache key so arm64/x64 browser caches stay separate.Validation
make lint-actionsmake static-checkgit diff --checkRisks
Low. This only changes CI cache paths/keys and setup-step timeouts. The main behavior change is that a future stalled browser install fails in 10 minutes rather than blocking the workflow for hours.
Generated with
mux• Model:openai:gpt-5.5• Thinking:xhigh• Cost:3451720{MUX_COSTS_USD:-unknown}