Merged
Conversation
Per the adapter maintainer upgrade guide for v1.6.0, this PR includes the following: Bugs fixed: - Fixed a bug causing the dateadd macro to fail its tests when handling DATETIME type fields. The updated sqlite__dateadd.sql macro now adequately handles both DATE and DATETIME types per ISO-8601 and passes its tests now. Changes made: [BtS] Adapter zone tests - Added four new tests in test_utils.py and all tests passed without overrides. No changes required: [BtS] Drop support for Py 3.7 - Support for Py 3.7 was already removed in dbt-sqlite 1.2.0rc1. [BtS] new arg for adapter.execute() - We use SQLConnectionManager.execute() directly. No changes required. No changes made: [FEATURE] Materialized Views: - Materialized views are not supported in sqlite3. No changes made. [FEATURE] dbt clone - Clone objects are not supported in sqlite3 because it is a simple in-process database. [BtS] revamp of dbt debug - No new warnings or errors in tests. No changes made. Possible remaining todo - Left out tests related to Contracts as they aren't being implemented as a feature. I had created a test and ran it only to see the test failed, which was expected, so the unit test needs to be overridden in order to make that passing criteria instead of failing.
Owner
|
This is fantastic! Everything looks really good here and ready to merge. |
|
@codeforkjeff do you think we can expect this PR merged and new version released to PyPI? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the adapter maintainer upgrade guide for v1.6.0, this PR includes the following:
Bugs fixed:
Changes made:
[BtS] Adapter zone tests
No changes required:
[BtS] Drop support for Py 3.7
[BtS] new arg for adapter.execute()
No changes made:
[FEATURE] Materialized Views:
[FEATURE] dbt clone
[BtS] revamp of dbt debug
Possible remaining todo: