Closed
Conversation
- sourced from MatthewPocock with a minor adjustment made to the anonymous telemetry `unique_key` to use socket.gethostname()
Remaining todo per upgrade guide: - stub materialized views (MV) as a materialization option to show users MV are not supported in sqlite - stub dbt_clone - add new available tests from 1.6.0 and re-test to find any remaining issues No action required: - Support for Python 3.7 is dropped - debug_query() does not need to be updated, as its not overwritten in our adapter code - We use SQLConnectionManager.execute() directly; no changes required
- mention this adapter works with v1.6.x in README
Collaborator
Author
|
Hi @codeforkjeff , here are my proposed updates for dbt-sqlite v1.6.0. Let me know if you'd like anything else here. |
Collaborator
Author
|
The commit history got messed up on my end. I'll resubmit a new PR with a simplified history. |
Collaborator
Author
|
Closing this PR -- new one opened here with a cleaner history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per the adapter maintainer upgrade guide for v1.6.0, this PR includes the following:
Bugs fixed:
Changes made:
[BtS] Adapter zone tests
No changes required:
[BtS] Drop support for Py 3.7
[BtS] new arg for
adapter.execute()No changes made:
[FEATURE] Materialized Views:
[FEATURE]
dbt clone[BtS] revamp of
dbt debugPossible remaining todo