Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
39313b9
git subrepo pull external/ag-shared
alantreadway Feb 20, 2026
2c3580d
git subrepo pull external/ag-shared
alantreadway Feb 20, 2026
5013a92
Integrate ag-shared subrepo changes into rulesync toolchain
alantreadway Feb 20, 2026
fd62008
Fix docs-review URL pattern and improve adaptive mode detection
alantreadway Feb 20, 2026
a7629c6
Replace docs-review either/or mode with layered browser testing approach
alantreadway Feb 20, 2026
bb7cde9
git subrepo push external/ag-shared
alantreadway Feb 20, 2026
9b270c4
Delegate docs-review browser testing to sonnet sub-agent using direct…
alantreadway Feb 20, 2026
9aad14a
git subrepo push external/ag-shared
alantreadway Feb 20, 2026
0d63032
Switch docs-review browser testing to parallel per-example haiku sub-…
alantreadway Feb 20, 2026
a0198d2
git subrepo push external/ag-shared
alantreadway Feb 20, 2026
38136cd
Add explicit parallel Task call template to docs-review step 5.3
alantreadway Feb 20, 2026
a4b9907
git subrepo push external/ag-shared
alantreadway Feb 20, 2026
c0742b7
Address PR #13182 review comments and fix similar issues
alantreadway Feb 23, 2026
08db58b
git subrepo push external/ag-shared
alantreadway Feb 23, 2026
2610667
git subrepo pull external/ag-shared
alantreadway Feb 23, 2026
2d1aa13
git subrepo pull external/ag-website-shared (#13185)
markdurrant Feb 23, 2026
3991668
Merge pull request #13182 from ag-grid/ajt/sync-ag-shared-20260220
alantreadway Feb 23, 2026
77bddaf
AG-16513 Added Theming API parameters page in API docs (#13186)
BernieSumption Feb 23, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions .rulesync/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,16 +53,27 @@ Quick-reference for all AI agent commands, skills, sub-agents, and rules availab
| Command | 🔵 `/plan-implementation-review` | `/plan-implementation-review` | Review plan execution, identify delivery gaps |
| Agent | 🔵 `nx-expert` | Auto | Nx monorepo configuration and build optimisation |

## Context and Memory

| Type | Name | Invoke | What it does |
| ------- | -------------- | ----------- | -------------------------------------------------- |
| Command | 🔵 `/remember` | `/remember` | Save branch context or project learnings as memory |
| Command | 🔵 `/recall` | `/recall` | Load branch context and browse project memory |

## Documentation Review

| Type | Name | Invoke | What it does |
| ------- | ------------------------- | ---------------------- | ---------------------------------------------------------------- |
| Command | 🟢 `/docs-review` | `/docs-review` | Review docs pages for technical accuracy and example consistency |
| Command | 🟢 `/release-docs-review` | `/release-docs-review` | Review all documentation changes between releases |

## Git and Branch Management

| Type | Name | Invoke | What it does |
| ------- | ----------------------------- | -------------------------- | ---------------------------------------------- |
| Command | 🔵 `/git-branch-save-context` | `/git-branch-save-context` | Save branch-specific context to `.context/` |
| Command | 🔵 `/git-branch-load-context` | `/git-branch-load-context` | Load branch-specific context from `.context/` |
| Command | 🔵 `/git-worktree-clean` | `/git-worktree-clean` | Hard-reset worktree to `origin/latest` |
| Command | 🔵 `/git-split` | `/git-split` | Split large files preserving git history |
| Command | 🔵 `/pr-split` | `/pr-split` | Split a branch into stacked PRs |
| Command | 🔵 `/context-remember` | `/context-remember` | Persist learnings from conversations as memory |
| Type | Name | Invoke | What it does |
| ------- | ------------------------ | --------------------- | ---------------------------------------- |
| Command | 🔵 `/git-worktree-clean` | `/git-worktree-clean` | Hard-reset worktree to `origin/latest` |
| Command | 🔵 `/git-split` | `/git-split` | Split large files preserving git history |
| Command | 🔵 `/pr-split` | `/pr-split` | Split a branch into stacked PRs |

---

Expand Down
1 change: 0 additions & 1 deletion .rulesync/commands/context-remember.md

This file was deleted.

7 changes: 3 additions & 4 deletions .rulesync/commands/docs-e2e-tests.md
Original file line number Diff line number Diff line change
Expand Up @@ -205,10 +205,9 @@ Group footer rows display `"Total {groupName}"` in the auto group column. Grand

```typescript
// Group footer
await expect(agIdFor.autoGroupCell('rowGroupFooter_row-group-country-Netherlands')).toContainText(
'Total Netherlands',
{ useInnerText: true }
);
await expect(agIdFor.autoGroupCell('rowGroupFooter_row-group-country-Netherlands')).toContainText('Total Netherlands', {
useInnerText: true,
});

// Grand total footer
await expect(agIdFor.autoGroupCell('rowGroupFooter_ROOT_NODE_ID').first()).toContainText('Total', {
Expand Down
125 changes: 125 additions & 0 deletions .rulesync/commands/docs-review.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,125 @@
---
targets: ['*']
description: 'Review documentation pages for technical accuracy and example consistency'
---

# Documentation Review - AG Grid

You are a technical documentation reviewer for AG Grid.

## Product Configuration

### Input Requirements

> Required — referenced by exact name in the core methodology.

User provides:

- Documentation page path: `documentation/ag-grid-docs/src/content/docs/${pageName}/index.mdoc`
- Live dev URL: `https://localhost:4610/javascript-data-grid/${pageName}/`

### Orchestration Indicator

- Orchestrator script: none

### File Resolution Rules

> Required — referenced by exact name in the core methodology.

Map documentation references to TypeScript definition files:

| If docs mention | Then check file |
| ----------------------------------------- | --------------------------------------------------------------------------------------------- |
| GridOptions / grid option property | `packages/ag-grid-community/src/entities/gridOptions.ts` |
| ColDef / column definition property | `packages/ag-grid-community/src/entities/colDef.ts` |
| Interface name like `I*` or specific type | Search `packages/ag-grid-community/src/**/*.ts` and `packages/ag-grid-enterprise/src/**/*.ts` |
| API function / grid API method | `packages/ag-grid-community/src/api/gridApi.ts` |

### Implementation Resolution Rules

> Required — referenced by exact name in the core methodology.

Map features to source implementation files:

| Feature Category | Implementation Path Pattern |
| ----------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------ |
| Row models (CSRM, SSRM, infinite, viewport) | `packages/ag-grid-community/src/clientSideRowModel/**/*.ts`, `packages/ag-grid-community/src/infiniteRowModel/**/*.ts`, `packages/ag-grid-enterprise/src/serverSideRowModel/**/*.ts`, `packages/ag-grid-enterprise/src/viewportRowModel/**/*.ts` |
| Column features (sizing, moving, pinning) | `packages/ag-grid-community/src/columns/**/*.ts`, `packages/ag-grid-community/src/columnMove/**/*.ts`, `packages/ag-grid-community/src/columnResize/**/*.ts`, `packages/ag-grid-community/src/columnAutosize/**/*.ts`, `packages/ag-grid-community/src/pinnedColumns/**/*.ts` |
| Cell editing | `packages/ag-grid-community/src/edit/**/*.ts` |
| Filtering | `packages/ag-grid-community/src/filter/**/*.ts`, `packages/ag-grid-enterprise/src/advancedFilter/**/*.ts` |
| Row grouping / pivoting | `packages/ag-grid-enterprise/src/rowGrouping/**/*.ts`, `packages/ag-grid-enterprise/src/pivot/**/*.ts` |
| Selection | `packages/ag-grid-community/src/selection/**/*.ts`, `packages/ag-grid-enterprise/src/rangeSelection/**/*.ts` |
| Export (CSV/Excel) | `packages/ag-grid-community/src/csvExport/**/*.ts`, `packages/ag-grid-enterprise/src/excelExport/**/*.ts` |
| Master detail | `packages/ag-grid-enterprise/src/masterDetail/**/*.ts` |
| Menu / context menu | `packages/ag-grid-enterprise/src/menu/**/*.ts` |
| Charts integration | `packages/ag-grid-enterprise/src/charts/**/*.ts` |
| Rich select / editors | `packages/ag-grid-enterprise/src/richSelect/**/*.ts` |
| Sorting | `packages/ag-grid-community/src/sort/**/*.ts` |
| Pagination | `packages/ag-grid-community/src/pagination/**/*.ts` |
| Tooltips | `packages/ag-grid-community/src/tooltip/**/*.ts` |
| Drag and drop / row drag | `packages/ag-grid-community/src/dragAndDrop/**/*.ts` |
| Keyboard navigation | `packages/ag-grid-community/src/navigation/**/*.ts` |
| Pinned rows | `packages/ag-grid-community/src/pinnedRowModel/**/*.ts` |
| Clipboard | `packages/ag-grid-enterprise/src/clipboard/**/*.ts` |
| Status bar | `packages/ag-grid-enterprise/src/statusBar/**/*.ts` |
| Side bar / tool panels | `packages/ag-grid-enterprise/src/sideBar/**/*.ts`, `packages/ag-grid-enterprise/src/columnToolPanel/**/*.ts`, `packages/ag-grid-enterprise/src/filterToolPanel/**/*.ts` |
| Set filter | `packages/ag-grid-enterprise/src/setFilter/**/*.ts` |
| Tree data | `packages/ag-grid-enterprise/src/treeData/**/*.ts` |
| Aggregation | `packages/ag-grid-enterprise/src/aggregation/**/*.ts` |
| Sparklines | `packages/ag-grid-enterprise/src/sparkline/**/*.ts` |

### Example Path Pattern

> Required — referenced by exact name in the core methodology.

`documentation/ag-grid-docs/src/content/docs/${pageName}/_examples/${exampleName}/`

- Required: `main.ts`
- Optional: `data.ts`, `styles.css`, `provided/modules/*`

### Example Direct URL Pattern

> Optional — referenced by exact name in the core methodology.

`https://localhost:4610/examples/${pageName}/${exampleName}/vanilla`

The `vanilla` framework variant is used as it loads slightly faster than `typescript`.

### Exceptions File Path

`documentation/ag-grid-docs/src/content/docs/${pageName}/technical-review-exceptions.md`

### Output Paths

> Required — referenced by exact name in the core methodology.

- Review plans: `reports/docs-review/plans/${pageName}.md`
- Reports: `documentation/ag-grid-docs/src/content/docs/${pageName}/reports/technical-review-report.md`
- Summary: `reports/docs-review/summary.md`

### Default Value Verification Hierarchy

> Required — referenced by exact name in the core methodology.

1. First: Check `packages/ag-grid-community/src/gridOptionsDefault.ts` for runtime defaults
2. Then: Check `packages/ag-grid-community/src/gridOptionsInitial.ts` for non-reactive properties (only read at grid initialisation)
3. Fallback: Check interface definition TypeScript comments in `entities/gridOptions.ts` or `entities/colDef.ts`
4. Verify: TypeScript JSDoc comments match actual runtime defaults

### Product-Specific Conventions

- Interface naming: `GridOptions`, `ColDef`, `ColGroupDef`, `RowNode`, `ICellRendererParams` etc.
- Column definitions use `ColDef` interface, not `ColumnDef`
- Grid API accessed via `api` property on the grid instance
- Enterprise features require `ag-grid-enterprise` package — docs should note enterprise-only features
- Examples support React, Angular, Vue 3 and vanilla JS frameworks

### Browser Testing Tips

> Required — referenced by exact name in the core methodology.

`.rulesync/rules/docs-review-testing.md`

## Review Methodology

**Read and follow all instructions in `external/ag-shared/prompts/commands/docs/_docs-review-core.md` for the review process, applying the product configuration above.**
1 change: 0 additions & 1 deletion .rulesync/commands/git-branch-load-context.md

This file was deleted.

1 change: 0 additions & 1 deletion .rulesync/commands/git-branch-save-context.md

This file was deleted.

1 change: 1 addition & 0 deletions .rulesync/commands/recall.md
65 changes: 65 additions & 0 deletions .rulesync/commands/release-docs-review.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
---
targets: ['*']
description: 'Review all documentation changes between releases for accuracy and completeness'
---

# Release Documentation Review - AG Grid

You are an expert documentation reviewer for AG Grid, specialising in
release documentation validation.

## Product Configuration

### Product

> Required — referenced by exact name in the core methodology.

- Name: AG Grid
- Docs review command: `/docs-review`

### Paths

> Required — referenced by exact name in the core methodology.

- Docs root: `documentation/ag-grid-docs/src/content/docs`
- Types root: `packages/ag-grid-community/src`
- Docs file pattern: `documentation/ag-grid-docs/src/content/docs/**/*.mdoc`
- Examples pattern: `documentation/ag-grid-docs/src/content/docs/**/_examples/`
- Types file pattern: `packages/ag-grid-community/src/**/*.ts`

### Release Branch Pattern

> Required — referenced by exact name in the core methodology.

- Format: `origin/bX.Y.Z`
- Discovery command: `git branch -r | grep 'origin/b[0-9]' | sort -V | tail -5`

### Priority Pages

> Required — referenced by exact name in the core methodology.

**High priority** (getting started, key features, upgrade guides):
`getting-started, quick-start, deep-dive, upgrading-to-ag-grid-34, row-data, column-definitions, grid-options, grid-interface`

**Medium priority** (core features):
`cell-editing, filtering, sorting, row-selection, cell-selection, row-grouping, server-side-model, master-detail, column-headers, themes, accessibility`

### Output Paths

> Required — referenced by exact name in the core methodology.

- Reports directory: `reports/`
- Filtered task list: `reports/release-docs-review-${PREVIOUS_BRANCH}-${CURRENT_BRANCH}-filtered.md`
- Complete task list: `reports/release-docs-review-${PREVIOUS_BRANCH}-${CURRENT_BRANCH}-tasks.md`
- Summary: `reports/release-docs-review-${PREVIOUS_BRANCH}-${CURRENT_BRANCH}-summary.md`

### Verification Paths

After each page review, confirm these files exist:

- `reports/docs-review/plans/${pageName}.md`
- `documentation/ag-grid-docs/src/content/docs/${pageName}/reports/technical-review-report.md`

## Review Methodology

**Read and follow all instructions in `external/ag-shared/prompts/commands/docs/_release-docs-review-core.md` for the review process, applying the product configuration above.**
1 change: 1 addition & 0 deletions .rulesync/commands/remember.md
6 changes: 5 additions & 1 deletion .rulesync/rules/ag-grid.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ This file provides guidance to AI Agents when working with code in this reposito
- **Build:** `yarn nx build <package>`
- **Test:** `yarn nx test <package>`
- **E2E:** `yarn nx e2e ag-grid-docs`
- **Dev server:** `yarn nx dev`
- **Dev server:** `yarn nx dev` (launches on https://localhost:4610/, check if it is already running before trying to run it)

### Content Locations

Expand Down Expand Up @@ -99,6 +99,10 @@ Run rulesync commands via slash notation:
- `/batch-lint-cleanup` - ESLint auto-fix tool
- `/git-split` - Split large files preserving git history
- `/git-bisect` - Find commits that introduced issues
- `/remember` - Save branch context or project learnings as memory
- `/recall` - Load branch context and browse project memory
- `/docs-review` - Review documentation pages for technical accuracy
- `/release-docs-review` - Review all documentation changes between releases

### Architecture

Expand Down
38 changes: 38 additions & 0 deletions .rulesync/rules/docs-review-testing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
---
targets: ['*']
description: 'Browser testing tips for documentation review'
---

# Documentation Review - Browser Testing

Tips for browser-testing AG Grid documentation pages via chrome automation.

## Page Navigation

- AG Grid example grids are rendered inside iframes. Scrolling while the cursor is over a grid example scrolls the grid's rows, not the page itself.
- To navigate down the page, scroll outside the grid area (e.g., over prose text or margins), or use keyboard navigation (`End`, `Home`, `Page Down`/`Page Up`).
- Use anchor links (`#section-name`) in the URL to jump directly to specific sections rather than scrolling through the entire page.

## Example Testing

- Each example has interactive controls (buttons, dropdowns) rendered above the grid iframe. Click them to verify the documented behaviour.
- After clicking an interactive control, take a screenshot to capture the result state.
- Check the browser console for errors after testing examples — expected messages like AG Grid Enterprise license warnings can be ignored.

## URL Pattern

- Dev server docs pages require a framework prefix: `https://localhost:4610/javascript-data-grid/${pageName}/`
- The framework prefix can be changed to test other frameworks: `react-data-grid`, `angular-data-grid`, `vue-data-grid`.

## Direct URL Testing (Sub-agent Mode)

When the product configuration includes an **Example Direct URL Pattern**, example browser testing is delegated to a `docs-example-browser-tester` sub-agent that opens each example at its standalone URL.

Direct URL characteristics:

- Examples render full-viewport with no docs page chrome, no iframe wrapper.
- Interactive controls (buttons, dropdowns) from the example's `index.html` are directly accessible without scrolling past documentation content.
- Console messages come from the example only, not the surrounding docs page.
- Screenshots capture the complete example without docs page chrome.

The main agent retains responsibility for page-level visual/interaction testing (Step 6) which requires the full docs page context (theme switchers, framework selectors, cross-references, keyboard navigation).
1 change: 1 addition & 0 deletions .rulesync/rules/nx-conventions.md
1 change: 1 addition & 0 deletions .rulesync/rules/setup-prompts.md
1 change: 1 addition & 0 deletions .rulesync/rules/website-astro-pages.md
1 change: 1 addition & 0 deletions .rulesync/rules/website-browser-testing.md
1 change: 1 addition & 0 deletions .rulesync/rules/website-css.md
1 change: 1 addition & 0 deletions .rulesync/subagents/docs-example-browser-tester.md
4 changes: 4 additions & 0 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ Run rulesync commands via slash notation:
- `/batch-lint-cleanup` - ESLint auto-fix tool
- `/git-split` - Split large files preserving git history
- `/git-bisect` - Find commits that introduced issues
- `/remember` - Save branch context or project learnings as memory
- `/recall` - Load branch context and browse project memory
- `/docs-review` - Review documentation pages for technical accuracy
- `/release-docs-review` - Review all documentation changes between releases

### Architecture

Expand Down
Loading
Loading