[pull] latest from ag-grid:latest#618
Merged
pull[bot] merged 18 commits intocode:latestfrom Feb 23, 2026
Merged
Conversation
subrepo: subdir: "external/ag-shared" merged: "032a0b07dce" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "032a0b07dce" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
subrepo: subdir: "external/ag-shared" merged: "4389a295dbc" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "4389a295dbc" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
Wire up new/reorganised ag-shared commands and guides after the subrepo pull: replace broken context-remember/branch-save/branch-load symlinks with consolidated /remember and /recall commands, add five new shared guide symlinks, and create AG Grid-specific /docs-review and /release-docs-review wrapper commands.
- Fix dev URL to include javascript-data-grid framework prefix - Clarify adaptive mode must check for chrome tools before falling back to degraded mode - Add docs-review-testing rule with browser testing tips (iframe scrolling, URL patterns)
The /docs-review command routinely skipped browser testing even when chrome tools were available. The root cause was an either/or framing (Full vs Degraded mode) that let the model opt into static-only analysis. Changes to _docs-review-core.md: - Replace ADAPTIVE/STRICT mode detection with layered approach: static analysis always runs, browser testing additionally runs when available - Add explicit tabs_context_mcp gate at start of Phase 2 with anti-skip directive - Add detailed browser testing procedures (numbered step-by-step) - Remove example-tester sub-agent dependency (always fell back to static-only since no product configured one) - Restructure Phase 2: browser session first, then static analysis, then browser verification - Update report structure and tool usage table to match Changes to docs-review.md: - Add Browser Testing Tips section referencing docs-review-testing.md Also includes rulesync formatting sync for README and release-docs-review.
subrepo: subdir: "external/ag-shared" merged: "5825cc4e8ce" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "5825cc4e8ce" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
… example URLs
Add docs-example-browser-tester agent that opens examples at standalone URLs
(e.g. /examples/{page}/{example}/vanilla) instead of scrolling through the
docs page iframe. The core methodology delegates to this sub-agent when an
Example Direct URL Pattern is configured, falling back to inline testing
otherwise.
subrepo: subdir: "external/ag-shared" merged: "76033962dd7" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "76033962dd7" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
…agents Spawning one sub-agent per example (instead of one per page) reduces context accumulation and hallucination risk. Using haiku instead of sonnet since the work is mechanical (navigate, screenshot, click, check console).
subrepo: subdir: "external/ag-shared" merged: "4984d05aaa0" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "4984d05aaa0" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
The instruction to spawn per-example sub-agents "via parallel Task tool calls in a single message" was too terse, causing the agent to spawn only a single sub-agent. Add an IMPORTANT callout with a concrete template showing the expected pattern of multiple Task calls in one message.
subrepo: subdir: "external/ag-shared" merged: "5d230a7e1f0" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "5d230a7e1f0" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
Fix inaccurate/incomplete content in docs-review configuration and remove product-specific references from shared ag-shared files. docs-review.md: - Add infinite and viewport row model paths - Add columnAutosize and pinnedColumns to column features - Fix gridOptionsInitial.ts description (non-reactive, not initial values) - Add 14 missing feature rows to Implementation Resolution Rules table ag-shared (genericise product-specific references): - docs-example-browser-tester: "AG Grid Enterprise" → "Enterprise" - _release-docs-review-core: remove AG Charts example path - pr/split: replace ag-grid.atlassian.net with generic placeholder - docs-review-integration: remove AG Charts references (3 instances)
subrepo: subdir: "external/ag-shared" merged: "cb8d4326a68" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "cb8d4326a68" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
subrepo: subdir: "external/ag-shared" merged: "cde57a75f60" upstream: origin: "https://github.com/ag-grid/ag-shared.git" branch: "latest" commit: "cde57a75f60" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "6e88ffd4d2"
subrepo: subdir: "external/ag-website-shared" merged: "3b77ba79f6" upstream: origin: "git@github.com:ag-grid/ag-website-shared.git" branch: "latest" commit: "3b77ba79f6" git-subrepo: version: "0.4.9" origin: "https://github.com/Homebrew/brew" commit: "999134536e"
Sync ag-shared and integrate rulesync toolchain updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )