Skip to content

style: reduce main header max-width to standard container size #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HarshMN2345 merged 2 commits into from
Apr 27, 2026
Merged

style: reduce main header max-width to standard container size #2914

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e064cc
reduce main header max-width to standard container size
HarshMN2345 Apr 27, 2026
d128783
fix init footer
HarshMN2345 Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/routes/(init)/init/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,8 +255,6 @@
.extended-borders-footer {
z-index: 0;
position: relative;
max-width: 100vw;
overflow: hidden;
}
.extended-borders-footer::before {
content: '';
Expand All @@ -265,9 +263,13 @@
pointer-events: none;
z-index: -1;
height: 0;
}

@media (min-width: 768px) {
inset: 0;
@media (min-width: 768px) {
.extended-borders-footer::before {
left: -100%;
right: -100%;
top: 0;
}
}
Comment on lines +268 to 274
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Potential horizontal overflow after removing overflow: hidden

The original code used overflow: hidden on .extended-borders-footer to clip the absolutely-positioned ::before pseudo-element within the viewport. That guard was removed, but the new left: -100%; right: -100% rule makes ::before extend one full container-width to each side. On a 1200 px container this renders the pseudo-element ~3600 px wide — well beyond the viewport — which will introduce a horizontal scrollbar unless a parent element already sets overflow-x: hidden. Please verify that nothing in the parent chain clips this overflow before shipping.


Expand Down
2 changes: 1 addition & 1 deletion src/scss/7-components/_main-header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
justify-content: center;
gap: pxToRem(16);
margin-inline: auto;
max-inline-size: pxToRem(1728);
max-inline-size: var(--container-size-normal);
padding-block: var(--p-main-header-padding-block);
}
&-start {
Expand Down
Loading