Skip to content

style: reduce main header max-width to standard container size#2914

Merged
HarshMN2345 merged 2 commits intomainfrom
tweak/header-width
Apr 27, 2026
Merged

style: reduce main header max-width to standard container size#2914
HarshMN2345 merged 2 commits intomainfrom
tweak/header-width

Conversation

@HarshMN2345
Copy link
Copy Markdown
Member

What does this PR do?

image

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@HarshMN2345 HarshMN2345 requested a review from eldadfux April 27, 2026 13:24
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 27, 2026

Greptile Summary

This PR reduces the main header wrapper's max-inline-size from the hard-coded pxToRem(1728) to the design token var(--container-size-normal) (1200 px), bringing it in line with the standard container width. It also refactors the extended-borders-footer::before pseudo-element on the init page to extend the dashed border edge-to-edge by using left: -100%; right: -100% after removing the previous overflow: hidden guard.

  • The removal of overflow: hidden and max-width: 100vw from .extended-borders-footer without a confirmed parent-level overflow clip risks introducing a horizontal scrollbar at all viewport widths where the pseudo-element extends beyond the viewport.

Confidence Score: 4/5

Safe to merge after verifying the horizontal overflow concern in the init page footer.

One P1 finding: removing overflow: hidden from .extended-borders-footer while the ::before pseudo-element now spans left: -100%; right: -100% may introduce a horizontal scrollbar unless a parent element already clips overflow. The SCSS change itself is clean and low-risk.

src/routes/(init)/init/+page.svelte — the extended-borders-footer overflow guard removal needs verification.

Important Files Changed

Filename Overview
src/scss/7-components/_main-header.scss Replaces hard-coded pxToRem(1728) with the design-token var(--container-size-normal) (1200 px), aligning the header wrapper with the standard container width.
src/routes/(init)/init/+page.svelte Refactors .extended-borders-footer pseudo-element: removes overflow: hidden / max-width: 100vw and extends ::before with left: -100%; right: -100%, which risks horizontal overflow if no ancestor clips it.

Reviews (2): Last reviewed commit: "fix init footer" | Re-trigger Greptile

Comment on lines +268 to 274
@media (min-width: 768px) {
.extended-borders-footer::before {
left: -100%;
right: -100%;
top: 0;
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Potential horizontal overflow after removing overflow: hidden

The original code used overflow: hidden on .extended-borders-footer to clip the absolutely-positioned ::before pseudo-element within the viewport. That guard was removed, but the new left: -100%; right: -100% rule makes ::before extend one full container-width to each side. On a 1200 px container this renders the pseudo-element ~3600 px wide — well beyond the viewport — which will introduce a horizontal scrollbar unless a parent element already sets overflow-x: hidden. Please verify that nothing in the parent chain clips this overflow before shipping.

@HarshMN2345 HarshMN2345 merged commit 720eb61 into main Apr 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants