style: reduce main header max-width to standard container size#2914
style: reduce main header max-width to standard container size#2914HarshMN2345 merged 2 commits intomainfrom
Conversation
Greptile SummaryThis PR reduces the main header wrapper's
Confidence Score: 4/5Safe to merge after verifying the horizontal overflow concern in the init page footer. One P1 finding: removing src/routes/(init)/init/+page.svelte — the extended-borders-footer overflow guard removal needs verification. Important Files Changed
Reviews (2): Last reviewed commit: "fix init footer" | Re-trigger Greptile |
| @media (min-width: 768px) { | ||
| .extended-borders-footer::before { | ||
| left: -100%; | ||
| right: -100%; | ||
| top: 0; | ||
| } | ||
| } |
There was a problem hiding this comment.
Potential horizontal overflow after removing
overflow: hidden
The original code used overflow: hidden on .extended-borders-footer to clip the absolutely-positioned ::before pseudo-element within the viewport. That guard was removed, but the new left: -100%; right: -100% rule makes ::before extend one full container-width to each side. On a 1200 px container this renders the pseudo-element ~3600 px wide — well beyond the viewport — which will introduce a horizontal scrollbar unless a parent element already sets overflow-x: hidden. Please verify that nothing in the parent chain clips this overflow before shipping.
What does this PR do?
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)