Skip to content

Revert "[Minor]: unify ANY/ALL planning and align ANY NULL semantics with PG (#21743)"#22345

Merged
adriangb merged 1 commit into
apache:mainfrom
alamb:alamb/revert_any_pruning
May 19, 2026
Merged

Revert "[Minor]: unify ANY/ALL planning and align ANY NULL semantics with PG (#21743)"#22345
adriangb merged 1 commit into
apache:mainfrom
alamb:alamb/revert_any_pruning

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented May 18, 2026

Which issue does this PR close?

Rationale for this change

As @cetra3 describes on #22073, in #21743 @berkaysynnada made a seemingly small change to align to postgres semantics that had much larger consequences

I think many users (for example @cetra3) will treat this change as a regression, and thus I think this issue would block the next datafusion release

We tried an alternate fix but it appears to also raise some subtle questions from @Jefffrey

Thus I think it is safest to revert the initial change and work out the better longer term fix before releasing

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Copy link
Copy Markdown
Contributor

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alamb . I agree with your assessment. Lets unblock this release and work from there.

@adriangb adriangb added this pull request to the merge queue May 19, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks May 19, 2026
@adriangb adriangb force-pushed the alamb/revert_any_pruning branch from 5f6e5b8 to d3064ea Compare May 19, 2026 17:50
@adriangb adriangb enabled auto-merge May 19, 2026 17:52
@adriangb adriangb added this pull request to the merge queue May 19, 2026
Merged via the queue into apache:main with commit 49876bf May 19, 2026
38 checks passed
@Jefffrey
Copy link
Copy Markdown
Contributor

Thanks for this, sorry didn't get around to reviewing this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sql SQL Planner sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PR #21743 disables Parquet pruning for = ANY([literals])

3 participants