Skip to content

feat(spark): port Spark-compatible Parquet schema adapter from Comet #22341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andygrove wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(spark): port Spark-compatible Parquet schema adapter from Comet #22341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0f7d9f
feat(spark): port Spark-compatible Parquet schema adapter from Comet
andygrove May 18, 2026
6aa9925
refactor(spark/parquet): code review cleanup
andygrove May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

22 changes: 20 additions & 2 deletions datafusion/spark/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,15 @@ all-features = true
[features]
default = []
core = ["datafusion"]
# Spark-compatible Parquet schema adapter (see `parquet` module).
parquet = [
"dep:datafusion-physical-expr",
"dep:datafusion-physical-expr-adapter",
"dep:datafusion-physical-expr-common",
"dep:datafusion-expr-common",
"dep:parquet",
"dep:uuid",
]

# Note: add additional linter rules in lib.rs.
# Rust does not support workspace + new linter rules in subcrates yet
Expand All @@ -53,24 +62,33 @@ datafusion-catalog = { workspace = true }
datafusion-common = { workspace = true }
datafusion-execution = { workspace = true }
datafusion-expr = { workspace = true }
datafusion-expr-common = { workspace = true, optional = true }
datafusion-functions = { workspace = true, features = ["crypto_expressions"] }
datafusion-functions-aggregate = { workspace = true }
datafusion-functions-aggregate-common = { workspace = true }
datafusion-functions-nested = { workspace = true }
datafusion-physical-expr = { workspace = true, optional = true }
datafusion-physical-expr-adapter = { workspace = true, optional = true }
datafusion-physical-expr-common = { workspace = true, optional = true }
log = { workspace = true }
num-traits = { workspace = true }
parquet = { workspace = true, optional = true }
percent-encoding = "2.3.2"
rand = { workspace = true }
serde_json = { workspace = true }
sha1 = "0.11"
sha2 = { workspace = true }
url = { workspace = true }
uuid = { workspace = true, optional = true }

[dev-dependencies]
arrow = { workspace = true, features = ["test_utils"] }
criterion = { workspace = true }
# for SessionStateBuilderSpark tests
datafusion = { workspace = true, default-features = false }
# for SessionStateBuilderSpark tests and Parquet schema-adapter tests
datafusion = { workspace = true, default-features = false, features = ["parquet"] }
futures = { workspace = true }
rand = { workspace = true }
tokio = { workspace = true }

[[bench]]
harness = false
Expand Down
2 changes: 2 additions & 0 deletions datafusion/spark/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@
//! for an example.

pub mod function;
#[cfg(feature = "parquet")]
pub mod parquet;
pub mod planner;

#[cfg(feature = "core")]
Expand Down
Loading
Loading