fix: lag i64::MIN offset overflow#22338
Open
chakkk309 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
lead/lagnormalize offsets internally by negating values in some cases. When the offset isi64::MIN, negating it overflows becausei64::MINcannot be represented as a positivei64.This can trigger an overflow panic instead of returning a proper DataFusion error.
What changes are included in this PR?
This PR rejects
i64::MINoffsets forlead/lagbefore they can be negated.It adds checked offset negation logic and returns an execution error like:
Are these changes tested?
Yes
Are there any user-facing changes?
Yes