feat: UNNEST with ordinality and offset support#22310
Open
MartinSahlen wants to merge 3 commits into
Open
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
UNNEST as a table factor previously rejected both WITH ORDINALITY (Postgres / SQL standard) and WITH OFFSET (BigQuery) with not_impl_err!. Both spellings express the same semantic need — emit a per-element position
alongside the unnested value — and the SQL parser (sqlparser-rs) already produces a single AST that distinguishes them by keyword.
Supporting both is justified by:
0-indexed), with no rewriting required.
indexing (arr[OFFSET(0)] vs arr[ORDINAL(1)]) — keyword carries the semantics, no surprise.
What changes are included in this PR?
works through the existing alias mechanism.
Are these changes tested?
Yes:
Are there any user-facing changes?
Yes — the SQL surface accepts UNNEST(...) WITH ORDINALITY [AS t(value_alias, ord_alias)] and UNNEST(...) WITH OFFSET [alias] in the FROM clause. The UnnestOptions public type gains a position field (additive, default
None); existing DataFrame callers are source-compatible.