Skip to content

Add SQL as a category in breaking API change policy#22179

Merged
alamb merged 3 commits into
mainfrom
alamb/breaking_changes_mo
May 20, 2026
Merged

Add SQL as a category in breaking API change policy#22179
alamb merged 3 commits into
mainfrom
alamb/breaking_changes_mo

Conversation

@alamb
Copy link
Copy Markdown
Contributor

@alamb alamb commented May 14, 2026

Which issue does this PR close?

Rationale for this change

As we have discovered, sometimes seemingly minor changes in SQL semantics have caused non trivial downstream pain, for example the recent changes to NULL semantics in ANY/ALL. See

What changes are included in this PR?

Add a note to the the API guide making it clear that changes to SQL semantics are also API changes too and deserve extra attention.

Are these changes tested?

By CI

Are there any user-facing changes?

Clearer API docs

@alamb alamb added the documentation Improvements or additions to documentation label May 14, 2026
@alamb alamb force-pushed the alamb/breaking_changes_mo branch from 2c389cb to cb692d4 Compare May 14, 2026 18:59
- Marking a function as deprecated (`#[deprecated]`)
- Adding a new function to a `trait` with a default implementation

### What is the public SQL API and what is a breaking SQL change?
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core reason for this API is to add this section

@alamb alamb marked this pull request as ready for review May 14, 2026 18:59
Copy link
Copy Markdown
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@alamb
Copy link
Copy Markdown
Contributor Author

alamb commented May 18, 2026

I'll leave this open for a few more days before merging it in

@alamb alamb added this pull request to the merge queue May 20, 2026
Merged via the queue into main with commit 70caf37 May 20, 2026
44 checks passed
@alamb alamb deleted the alamb/breaking_changes_mo branch May 20, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants