Use BooleanBuffer bitwise ops instead of arrow::compute::and#21338
Closed
Dandandan wants to merge 1 commit intoapache:mainfrom
Closed
Use BooleanBuffer bitwise ops instead of arrow::compute::and#21338Dandandan wants to merge 1 commit intoapache:mainfrom
Dandandan wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
physical-expr
Replace `arrow::compute::and()` calls with `BooleanBuffer` bitwise operations (`&`, `&=`) where possible. This avoids allocating intermediate BooleanArrays with null handling overhead. - catalog/table.rs: accumulate filter masks with `BooleanBuffer &=` - joins/utils.rs: fold equality results with `BooleanBuffer &=` - metadata.rs: combine eq/exactness masks with `BooleanBuffer &` - correlation.rs: combine is_not_null results with `BooleanBuffer &` - approx_percentile_cont_with_weight.rs: same pattern Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Dandandan
force-pushed
the
bitwise-assign
branch
from
8fae761 to
401ef47
Compare
github-actions
bot
removed
physical-expr
Contributor
Author
|
run benchmarks |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing bitwise-assign (401ef47) to 1e93a67 (merge-base) diff using: clickbench_partitioned File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing bitwise-assign (401ef47) to 1e93a67 (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing bitwise-assign (401ef47) to 1e93a67 (merge-base) diff using: tpcds File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpcds — base (merge-base)
tpcds — branch
File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usageclickbench_partitioned — base (merge-base)
clickbench_partitioned — branch
File an issue against this benchmark runner |
Contributor
|
run benchmark tpch |
alamb
reviewed
Apr 3, 2026
| } | ||
|
|
||
| let mut combined_mask: Option<BooleanArray> = None; | ||
| let mut combined_buf: Option<BooleanBuffer> = None; |
Contributor
There was a problem hiding this comment.
What do you think about implementing this API:
We could then use it for these cases 🤔
Contributor
Author
There was a problem hiding this comment.
Yeah it is a good idea!
I don't see yet any real e2e improvements so closing this one for now :)
|
🤖 Benchmark running (GKE) | trigger CPU Details (lscpu)Comparing bitwise-assign (401ef47) to 1e93a67 (merge-base) diff using: tpch File an issue against this benchmark runner |
|
🤖 Benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagetpch — base (merge-base)
tpch — branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A - minor optimization
Rationale for this change
arrow::compute::and()operates onBooleanArrayand includes null-handling overhead (computing output null buffer). In many cases, we can useBooleanBufferbitwise operations (&,&=) directly, which:BooleanArrays with null buffers&=(no new allocation per iteration)is_not_null()results)What changes are included in this PR?
Replace
arrow::compute::and()withBooleanBufferbitwise operations in 5 files:catalog/table.rs: Filter mask accumulation loop →BooleanBuffer &=in-placejoins/utils.rs: Equality result fold → explicit loop withBooleanBuffer &=metadata.rs: Combining eq/exactness masks →BooleanBuffer &correlation.rs: Combiningis_not_null()results →values() & values()(no nulls)approx_percentile_cont_with_weight.rs: Sameis_not_null()patternWhere inputs may have nulls (filters, eq results), null values are converted to false at the buffer level via
values() & nulls.inner()before combining.Are these changes tested?
Existing tests cover these code paths.
Are there any user-facing changes?
No.
🤖 Generated with Claude Code