fix: median retract logic for sliding window frames#21300
Open
lyne7-sc wants to merge 1 commit intoapache:mainfrom
Open
fix: median retract logic for sliding window frames#21300lyne7-sc wants to merge 1 commit intoapache:mainfrom
median retract logic for sliding window frames#21300lyne7-sc wants to merge 1 commit intoapache:mainfrom
Conversation
github-actions
bot
added
sqllogictest
lyne7-sc
commented
Apr 1, 2026
| break; | ||
| } | ||
| } | ||
| } else { |
Contributor
Author
There was a problem hiding this comment.
this should be simple, just re-check index i after swap_remove(i).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
medianwindow function can skip retracted values in sliding frames #21299.Rationale for this change
mediancould produce incorrect results for sliding window frames becauseMedianAccumulator::retract_batchcould skip values afterswap_remove(i).When an element was removed, the last element was moved into index
i, but the loop still incrementedi. That meant the swapped-in value was never checked, so not all requested values were retracted.What changes are included in this PR?
retract_batchso the index is only advanced when no value is removedmedianover a slidingrangewindowAre these changes tested?
Yes.
Are there any user-facing changes?
No.