-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: datatype_is_logically_equal for dictionaries #20153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
notfilippo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me! Thanks :)
gabotechs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! thanks @dd-annarose
df92e66 to
321b285
Compare
1a0c600 to
09c29d7
Compare
|
does anyone know why the |
|
(trying to retrigger something sorry for the noise everyone) |
|
No idea; maybe we missed our daily prayers to the GitHub Actions gods? Tried rerunning that specific job to no avail 🙁 |
|
Seeing if merging up from main might help 🤔 |
|
Seems to be having same problem; looks like it perhaps is running but we can't get the logs somehow? 🤔 |
|
We did recently change the runner to an AWS runner: I guess it's related to that if it's only this job being blocked; cc @blaginin |
|
lets see if it'll get picked up 👀 |
|
seems like an issue on the asf infra side, pinged the team (cc @gmcdonald), let me know if you need to merge this PR urgently |
|
Hey, I think I now understand the issue. We have a bug where reruns of the action don't work for some reason. The author of this PR hasn't committed to datafusion yet, so the action requires manual approval - and the first run is always cancelled. I'm trying to figure it out. In the meantime, here's the working CI for this PR: https://github.com/apache/datafusion-sandbox/actions/runs/21755022756 Can confirm the CI is fully green ✅ |
Nice, is it fine if we merge this now then? |
|
good by me! |
|
In it goes |
Which issue does this PR close?
When checking logical equivalence with
Dictionary<_, Utf8>andUtf8View, the response wasfalsewhich is not what we expect (logical equivalence should be a transitive property).What changes are included in this PR?
This PR introduces a test and a fix. The test fails without the fix. The fix is simply calling
datatype_is_logically_equalagain on thev1andothertypewhen called withDictionary<K1, V1>andothertype.Are these changes tested?
Yes.
Are there any user-facing changes?
No.