fix: handle mark joins correctly in optimize_projections#20084
Open
mohanakatari119-bit wants to merge 1 commit intoapache:mainfrom
Open
fix: handle mark joins correctly in optimize_projections#20084mohanakatari119-bit wants to merge 1 commit intoapache:mainfrom
mohanakatari119-bit wants to merge 1 commit intoapache:mainfrom
Conversation
Fixes schema mismatch error when EXISTS subqueries in OR conditions are followed by join operations. LeftMark and RightMark joins have a synthetic mark column that shouldn't be routed to child nodes. Fixes apache#20083
Author
Contributor
|
Thank you for the PR @mohanakatari119-bit -- Can you please Fix the CI tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
For LeftMark/RightMark joins:
[left columns, mark column](for LeftMark) or[right columns, mark column](for RightMark)split_join_requirementssplit indices atleft_len, it incorrectly tried to route the mark column requirement to the right childSolution
Modified
split_join_requirementsto handle LeftMark and RightMark joins specially:left_lento left child, discard mark column requirementleft_lento right child, discard mark column requirementTest Plan
Added test
exists_or_exists_with_jointhat:EXISTS(subquery_a) OR EXISTS(subquery_b)filter