refactor: extract pushdown test utilities to shared module#20010
Merged
refactor: extract pushdown test utilities to shared module#20010
Conversation
Move TestSource, TestOpener, TestScanBuilder, OptimizationTest and related utilities from filter_pushdown/util.rs to a new shared pushdown_utils.rs module. This allows these utilities to be reused by other pushdown tests like projection_pushdown. Also update TestOpener and TestSource to use ProjectionExprs instead of Vec<usize> for projections, enabling support for complex projection expressions (e.g. get_field). Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Jefffrey
approved these changes
Jan 27, 2026
xudong963
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Working on #19538 I found that this refactor was necessary to be able to test more advanced projection expression pushdown functionality.
Summary
Move TestSource, TestOpener, TestScanBuilder, OptimizationTest and related utilities from
filter_pushdown/util.rsto a new sharedpushdown_utils.rsmodule. This allows these utilities to be reused by other pushdown tests like projection_pushdown.Key changes:
datafusion/core/tests/physical_optimizer/pushdown_utils.rsProjectionExprsinstead ofVec<usize>for projectionsget_field)Test Plan
🤖 Generated with Claude Code